Skip to content

Updated browserVersion and version to behave the same#1117

Open
samends wants to merge 1 commit intotheintern:master-oldfrom
samends:ISSUE-1113-browserVersion
Open

Updated browserVersion and version to behave the same#1117
samends wants to merge 1 commit intotheintern:master-oldfrom
samends:ISSUE-1113-browserVersion

Conversation

@samends
Copy link
Copy Markdown

@samends samends commented Feb 29, 2020

When version is set to insider preview and browserName is MicrosoftEdge, the driver name should be MicrosoftEdgeChromium

resolves: #1113

- When version is set to 'insider preview' and browserName is 'MicrosoftEdge', the driver name should be 'MicrosoftEdgeChromium
@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented Feb 29, 2020

CLA assistant check
All committers have signed the CLA.

@samends samends changed the title bug: Updated browserVersion and version to behave the same Updated browserVersion and version to behave the same Feb 29, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 29, 2020

Codecov Report

Merging #1117 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   57.44%   57.34%   -0.11%     
==========================================
  Files          95       95              
  Lines        8909     8911       +2     
  Branches     2046     2048       +2     
==========================================
- Hits         5118     5110       -8     
- Misses       3791     3801      +10
Impacted Files Coverage Δ
src/core/lib/executors/Node.ts 90% <0%> (-0.35%) ⬇️
src/tunnels/BrowserStackTunnel.ts 80.53% <0%> (-1.77%) ⬇️
src/common/lib/request.ts 52.2% <0%> (-0.74%) ⬇️
src/webdriver/Server.ts 33.93% <0%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2297e7b...c44d62b. Read the comment docs.

Copy link
Copy Markdown
Member

@jason0x43 jason0x43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does handle the Edge case, but we should try to deal with this at an earlier point if possible, possibly in src/core/lib/common/util#processOption, to cover that and the BrowserStack case.

@jason0x43 jason0x43 changed the base branch from master to master-old August 25, 2020 15:52
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.34%. Comparing base (2297e7b) to head (c44d62b).
⚠️ Report is 48 commits behind head on master-old.

Files with missing lines Patch % Lines
src/core/lib/executors/Node.ts 0.00% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff               @@
##           master-old    #1117      +/-   ##
==============================================
- Coverage       57.44%   57.34%   -0.11%     
==============================================
  Files              95       95              
  Lines            8909     8911       +2     
  Branches         2046     2048       +2     
==============================================
- Hits             5118     5110       -8     
- Misses           3791     3801      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different behavior for browserVersion and version

5 participants