Updated browserVersion and version to behave the same#1117
Updated browserVersion and version to behave the same#1117samends wants to merge 1 commit intotheintern:master-oldfrom
Conversation
- When version is set to 'insider preview' and browserName is 'MicrosoftEdge', the driver name should be 'MicrosoftEdgeChromium
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
==========================================
- Coverage 57.44% 57.34% -0.11%
==========================================
Files 95 95
Lines 8909 8911 +2
Branches 2046 2048 +2
==========================================
- Hits 5118 5110 -8
- Misses 3791 3801 +10
Continue to review full report at Codecov.
|
jason0x43
left a comment
There was a problem hiding this comment.
This does handle the Edge case, but we should try to deal with this at an earlier point if possible, possibly in src/core/lib/common/util#processOption, to cover that and the BrowserStack case.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-old #1117 +/- ##
==============================================
- Coverage 57.44% 57.34% -0.11%
==============================================
Files 95 95
Lines 8909 8911 +2
Branches 2046 2048 +2
==============================================
- Hits 5118 5110 -8
- Misses 3791 3801 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When version is set to
insider previewand browserName isMicrosoftEdge, the driver name should beMicrosoftEdgeChromiumresolves: #1113