fix(login): add protocol selector and auto-normalize admin API URL#3
Open
KamyarAT wants to merge 1 commit into
Open
fix(login): add protocol selector and auto-normalize admin API URL#3KamyarAT wants to merge 1 commit into
KamyarAT wants to merge 1 commit into
Conversation
Users could not log in when the Admin API URL omitted https:// because the field required a full URL. Split the login input into a protocol dropdown (default HTTPS) and host/path field, normalize URLs on connect, and accept pasted full URLs by splitting them into both controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
your-server.com/api/adminwith HTTPS selected and connect successfullyhttps://host/api/adminand confirm fields split correctly