Reorganize test suite for better maintainability#753
Merged
Conversation
- Merge cell-formatting.test.ts into cells.test.ts - Split manage.test.ts into focused files: - manage.test.ts: doc & sheet lifecycle only - worksheet-operations.test.ts: data manipulation operations - worksheet-features.test.ts: worksheet features (filters, formatting, metadata) - Fix WorksheetDimensionProperties type to accept Partial for updateDimensionProperties This reorganization makes the test suite more maintainable by grouping related tests together and splitting the large manage.test.ts file into logical units. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
- Google API omits properties with 0 values (green/blue in backgroundColor) - textRotation is a oneof field - can only set angle OR vertical, not both - Just verify textRotation is set without checking specific angle value Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganizes the test suite for better maintainability and clarity by grouping related tests together and splitting large test files into focused units.
Changes
Test File Reorganization
cell-formatting.test.tsintocells.test.ts: Cell formatting tests now live alongside other cell operationsmanage.test.ts: Now focused solely on document and sheet lifecycle operationsworksheet-operations.test.ts: Contains all data manipulation operations (paste, sort, trim, etc.)worksheet-features.test.ts: Contains worksheet features like filters, conditional formatting, banding, and developer metadataType Fix
updateDimensionPropertiesto acceptPartial<WorksheetDimensionProperties>instead of requiring all propertiesFiles Changed
src/lib/GoogleSpreadsheetWorksheet.ts- Type fix for updateDimensionPropertiessrc/test/cells.test.ts- Now includes cell formatting testssrc/test/manage.test.ts- Trimmed to doc/sheet lifecycle onlysrc/test/worksheet-operations.test.ts- New file with data operationssrc/test/worksheet-features.test.ts- New file with worksheet featuressrc/test/cell-formatting.test.tsVerification
🤖 Generated with Claude Code