Use FixtureStore to get manager name instead of deprecated static::$m…#109
Open
madkot wants to merge 1 commit intotheofidry:mainfrom
Open
Use FixtureStore to get manager name instead of deprecated static::$m…#109madkot wants to merge 1 commit intotheofidry:mainfrom
madkot wants to merge 1 commit intotheofidry:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a need to use other manager name than default one to build schema we will have an deprecation notice like:
1x: Since hautelook/alice-bundle 2.12.2: Setting up the database manager via the class static is deprecated. Use FixtureStore::setManagerName() instead.
To be consistent, once you set static::$manager as deprecated, you should get rid of its use.
Here is the deprecation:
AliceBundle/src/PhpUnit/BaseDatabaseTrait.php
Line 86 in 0442ebc
PS I haven't checked the compatibility of this change. I only see a lack of consistency.