Open
Conversation
Owner
|
Hi @lofcz thanks for the changes! I started reviewing them here - but I'll need to do some more testing before merging. One issue I found was when starting the sample app using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates included SocketIO code to 8d5d25c51ac6257f4bcbe8cf0c67d097ecb2861f.
This comes with three benefits:
whileloops)The only front-facing change is
EIOchanged toEnumfromint, which is reflected inBridgeConnector.I've tested
SampleAppagainst this branch and it works.Edit 1: updated to 8d5d25c51ac6257f4bcbe8cf0c67d097ecb2861f