Skip to content

Removing Writer/Reader from instance node name #22

Open
dupontz wants to merge 3 commits into
theonestack:masterfrom
dupontz:master
Open

Removing Writer/Reader from instance node name #22
dupontz wants to merge 3 commits into
theonestack:masterfrom
dupontz:master

Conversation

@dupontz

@dupontz dupontz commented Sep 17, 2025

Copy link
Copy Markdown

No description provided.

@dupontz

dupontz commented Sep 17, 2025

Copy link
Copy Markdown
Author
Screenshot 2025-09-17 at 16 50 04

Here is how it will look like

@LewS LewS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoids the confusion of misnamed writer/reader instances, but there is also the r53 records, which I'm less sure that we need. The problem with renaming these resources is that it will create new resources for any stack not using a locked version of the component. I think we should consider the creation of a couple of conditions, so that the old behavior defaults and the new behavior can be chosen.

Comment thread aurora-postgres.cfndsl.rb

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoids the confusion of misnamed writer/reader instances, but there is also the r53 records, which I'm less sure that we need. The problem with renaming these resources is that it will create new resources for any stack not using a locked version of the component. I think we should consider the creation of a couple of conditions, so that the old behavior defaults and the new behavior can be chosen.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's going to add nodes to the cluster, there is going to failover at some point. Route53 is pointing to the cluster-endpoint, or at least should be. Let's see if others agree on the naming them we can have another thread on how to rollout

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of anything better for the naming convention, my only thought was something like DBClusterInstancePeer for the reader(s), suggesting that they're the same (though maybe it would be too misleading). Clone? Twin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants