Fix Widget Spacing in Onigiri by adding Padding and Margin Sliders - #4
Open
autumngalaxy wants to merge 3 commits into
Open
Fix Widget Spacing in Onigiri by adding Padding and Margin Sliders#4autumngalaxy wants to merge 3 commits into
autumngalaxy wants to merge 3 commits into
Conversation
Made .senchado-widget's padding and margin 0 in main_widget.py to make it fit Onigiri widgets better.
Ties the front end to the backend of the padding and margin sliders
Owner
|
Hi there @autumngalaxy thank you so much! I'll test those on my end and push asap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I noticed that Senchado's widget didn't space properly inside of my Onigiri when size was set to Medium or Big, instead not being quite as tall as other widgets around it (See below)
Description
Added "Padding" and "Margin" sliders to the settings menu, with a range of 0-20px each, and made them update the widget accordingly.
This is the widget on 0px Padding and Margin, on "Big" size:
Files changed
config.json
Added "padding" and "margin" attributes to ui_settings, with default 20px each.
config.py
Added "padding" and "margin" attributes to ui_settings in the default config, with default 20px each.
main_widget.py
Added "padding" and "margin" to properly update the widget's CSS attributes
meta.json
Added "padding" and "margin" attributes to ui_settings, with default 20px each.
settings.py
Added "Padding" and "Margin" sliders to the settings menu, with a range of 0-20px each, and styles from the Opacity and Blur sliders.