Skip to content

Fix P0-P2 bugs: Gremlin injection, property mismatches, Neptune auth, collector correctness#7

Merged
therandomsecurityguy merged 2 commits into
mainfrom
feature/bug-fixes
Jun 22, 2026
Merged

Fix P0-P2 bugs: Gremlin injection, property mismatches, Neptune auth, collector correctness#7
therandomsecurityguy merged 2 commits into
mainfrom
feature/bug-fixes

Conversation

@Shasheen8

Copy link
Copy Markdown
Collaborator

Foundation fixes across the platform

  • Gremlin injection eliminated in graph-writer, incremental-collector, policy-evaluator, and API neptune-client — all queries now use Gremlin bindings instead of string interpolation
  • Risk rules fixed — all 10 rules rewritten with correct snake_case property names and vertex labels matching collector output; rules now reference edges that actually exist (ATTACHED_TOCONTAINSGRANTS instead of non-existent ALLOWS_ACCESS_TO)
  • Neptune auth added to API service — reads NEPTUNE_AUTH_SECRET_ARN and fetches credentials from Secrets Manager
  • Stub getSecret removed from types.ts that returned hardcoded fake credentials
  • Collector correctness — fixed malformed SG edge ARN, VPC flow logs now actually queried via DescribeFlowLogs, Security Hub findings fully paginated, ExternalId added to cross-account AssumeRoleCommand calls
  • Collector enhancementsHAS_IAM_ROLE edges added for EC2 and Lambda, port_from/port_to on SecurityGroupRule, is_in_vpc/has_internet_access on Lambda, has_wildcard_resource/has_wildcard_action on IamPolicyStatement, is_publicly_accessible on RDS
  • CDKSecurityGraphEksStack conditionally instantiated, DynamoDB tables exposed as stack properties
  • CI — fixed release workflow paths (lambdas/risk-enginepackages/risk-engine)
  • API — CORS middleware added with configurable allowed origins, Gremlin validator extended with ARN param validation
  • Compliance — duplicate CIS controls removed (1.9, 1.16, 1.17, 1.18), DynamoDB client instances deduplicated in compliance engine
  • Cleanup — removed conflicting .eslintrc.json, dead neptune-client-lite.ts, compiled artifacts from git tracking
  • UI — fixed downloadReport to use NEXT_PUBLIC_API_URL instead of relative path
  • ARCHITECTURE.md — updated diagram, vertex/edge schema, and risk rule properties to match code

…auth, collector correctness, CDK and CI fixes
@Shasheen8 Shasheen8 force-pushed the feature/bug-fixes branch from 3488757 to 4b93afd Compare June 22, 2026 19:31
@therandomsecurityguy therandomsecurityguy merged commit e4700b1 into main Jun 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants