Skip to content

some performance improvements for CodeFull.gs #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brightening-eyes wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −17
Open

some performance improvements for CodeFull.gs #1254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions assets/apps_script/CodeFull.gs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,15 +395,8 @@ function _doBatch(items) {
}
var fallbackReq = fetchArgs[j];
var fallbackUrl = fallbackReq.url;
var fallbackOpts = {};
for (var key in fallbackReq) {
if (
Object.prototype.hasOwnProperty.call(fallbackReq, key) &&
key !== "url"
) {
fallbackOpts[key] = fallbackReq[key];
}
}
var fallbackOpts = Object.assign({}, fallbackReq);
delete fallbackOpts.url;
responses[j] = UrlFetchApp.fetch(fallbackUrl, fallbackOpts);
} catch (singleErr) {
errorMap[fetchIndex[j]] = String(singleErr);
Expand Down Expand Up @@ -608,12 +601,12 @@ function _edgeDnsResolve(prep, cachedReplyB64, cache, localMap) {
function _sha256Hex(s) {
var d = Utilities.computeDigest(
Utilities.DigestAlgorithm.SHA_256, s, Utilities.Charset.UTF_8);
var hex = "";
var parts = [];
for (var i = 0; i < d.length; i++) {
var b = d[i] & 0xFF;
hex += (b < 16 ? "0" : "") + b.toString(16);
parts.push((b < 16 ? "0" : "") + b.toString(16));
}
return hex;
return parts.join("");
}

// Single DoH GET against `url`. Returns the reply as a byte array, or null
Expand Down Expand Up @@ -656,13 +649,13 @@ function _dnsParseQuestion(bytes) {
if (len > 63) return null;
off++;
if (off + len > bytes.length) return null;
var label = "";
var labelChars = [];
for (var i = 0; i < len; i++) {
var c = bytes[off + i] & 0xFF;
if (c >= 0x41 && c <= 0x5A) c += 0x20; // ASCII lowercase
label += String.fromCharCode(c);
labelChars.push(String.fromCharCode(c));
}
labels.push(label);
labels.push(labelChars.join(""));
off += len;
nameLen += len + 1;
if (nameLen > 255) return null;
Expand Down Expand Up @@ -743,8 +736,7 @@ function _dnsSkipName(bytes, off) {
// cheap (~100 bytes for a typical DNS reply) compared to the surrounding
// base64 encode/decode work.
function _dnsRewriteTxid(bytes, txid) {
var out = [];
for (var i = 0; i < bytes.length; i++) out.push(bytes[i]);
var out = Array.prototype.slice.call(bytes);
var hi = (txid >> 8) & 0xFF;
var lo = txid & 0xFF;
out[0] = hi > 127 ? hi - 256 : hi;
Expand Down
Loading