Skip to content

ASoC: SOF: ipc4-loader: remove the CPC check warnings #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plbossart merged 1 commit into from
Dec 21, 2023
Merged

ASoC: SOF: ipc4-loader: remove the CPC check warnings #4753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions sound/soc/sof/ipc4-loader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,13 +482,10 @@ void sof_ipc4_update_cpc_from_manifest(struct snd_sof_dev *sdev,
msg = "No CPC match in the firmware file's manifest";

no_cpc:
dev_warn(sdev->dev, "%s (UUID: %pUL): %s (ibs/obs: %u/%u)\n",
fw_module->man4_module_entry.name,
&fw_module->man4_module_entry.uuid, msg, basecfg->ibs,
basecfg->obs);
dev_warn_once(sdev->dev, "Please try to update the firmware.\n");
dev_warn_once(sdev->dev, "If the issue persists, file a bug at\n");
dev_warn_once(sdev->dev, "https://github.com/thesofproject/sof/issues/\n");
dev_dbg(sdev->dev, "%s (UUID: %pUL): %s (ibs/obs: %u/%u)\n",
fw_module->man4_module_entry.name,
&fw_module->man4_module_entry.uuid, msg, basecfg->ibs,
basecfg->obs);

@ujfalusi ujfalusi Dec 20, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why it ended up as dev_warn() + dev_warn_once() is to make sure it shows up in the logs and 'annoy' users that they will file a bug so the CPC value is fixed. Initially I had dev_dbg() as well.
Do we need to print it every time a stream starts? Would a dev_dbg_once() can suffice? Well, it is dev_dbg(), so only developers going to see it, right?

@kv2019i kv2019i Dec 21, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original intent still has merit. It's just we need to scale back on the "annoy dose" given the fixes come via quarterly SOF releases (plus adoption to upstream). You can add or modify a tplg at any time, but you can't get rid of the warnings without a new (typically signed) image.

}

const struct sof_ipc_fw_loader_ops ipc4_loader_ops = {
Expand Down