sof: ipc: switch platform IPC to Zephyr service #10422
Open
+52
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmleman
requested review from
bardliao,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko and
plbossart
as code owners
There was a problem hiding this comment.
Pull request overview
This PR migrates SOF's platform IPC implementation from the Intel-specific ADSP IPC driver to the generic Zephyr ipc_service API, enabling better integration with Zephyr and easier vendor customization.
Key Changes:
- Replaced direct
intel_adsp_ipc_*()calls withipc_service_*()API calls throughout the IPC path - Introduced
sof_ipc_receive_cb()as the new IPC service endpoint callback handler - Added compile-time assertion to validate IPC header format assumptions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| west.yml | Updates Zephyr dependency to a PR branch containing the required IPC service changes |
| src/ipc/ipc-zephyr.c | Replaces Intel ADSP IPC driver calls with generic Zephyr IPC service API, registers endpoint, and updates message handling callbacks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmleman
force-pushed
the
topic/upstream/pr/intel/ace/ipc_rework
branch
2 times, most recently
from
a2b58ca to
96221b4
Compare
Member
|
@tmleman Jenkins results are good atm. |
wjablon1
reviewed
Jan 15, 2026
wjablon1
reviewed
Jan 15, 2026
wjablon1
reviewed
Jan 15, 2026
tmleman
force-pushed
the
topic/upstream/pr/intel/ace/ipc_rework
branch
2 times, most recently
from
3d04a00 to
d392fd1
Compare
tmleman
changed the title
tmleman
requested review from
abonislawski,
serhiy-katsyuba-intel and
softwarecki
serhiy-katsyuba-intel
approved these changes
Jan 19, 2026
This patch reworks the SOF IPC platform integration to use the generic Zephyr ipc_service instead of the Intel audio DSP specific driver. Before this change SOF was talking directly to the Intel ADSP IPC driver, which made the IPC path tightly coupled to that particular backend. All commands were sent and completed via intel_adsp_ipc_*() functions. The code now sends and receives IPC commands through a Zephyr ipc_service endpoint registered on the Intel ADSP host IPC instance, using sof_ipc_receive_cb() as the receive handler. Incoming messages are processed as before using the existing compact IPC path to process commands. Each IPC command is treated as a compact two-word ipc_cmd_hdr and a BUILD_ASSERT guarantees that the header size remains aligned with the transport format assumptions. This change is part of ongoing work to better integrate SOF with Zephyr and will allow other vendors to more easily integrate their own IPC backends. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
tmleman
force-pushed
the
topic/upstream/pr/intel/ace/ipc_rework
branch
from
d392fd1 to
b793a0b
Compare
lgirdwood
approved these changes
Jan 19, 2026
Member
|
@kv2019i pls take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reworks the SOF IPC platform integration to use the generic Zephyr ipc_service instead of the Intel audio DSP specific driver.
Before this change SOF was talking directly to the Intel ADSP IPC driver, which made the IPC path tightly coupled to that particular backend. All commands were sent and completed via intel_adsp_ipc_*() functions.
The code now sends and receives IPC commands through a Zephyr ipc_service endpoint registered on the Intel ADSP host IPC instance, using sof_ipc_receive_cb() as the receive handler. Incoming messages are processed as before using the existing compact IPC path to process commands.
Each IPC command is treated as a compact two-word ipc_cmd_hdr and a BUILD_ASSERT guarantees that the header size remains aligned with the transport format assumptions.
This change is part of ongoing work to better integrate SOF with Zephyr and will allow other vendors to more easily integrate their own IPC backends.