Skip to content

platform: intel: ace: fix is_uncached() definition #10788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
May 19, 2026
Merged

platform: intel: ace: fix is_uncached() definition #10788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/intel/ace/include/ace/lib/memory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

#define uncache_to_cache(address) sys_cache_cached_ptr_get(address)
#define cache_to_uncache(address) sys_cache_uncached_ptr_get(address)
#define is_uncached(address) sys_cache_is_ptr_cached(address)
#define is_uncached(address) (!sys_cache_is_ptr_cached(address))

@lyakh lyakh May 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. But I don't see it used anywhere? It's used in src/include/sof/coherent.h but only when certain macros are defined, specifically COHERENT_CHECK_ALIAS or COHERENT_CHECK_NONSHARED_CORES and those macros seem to never be defined... coherent.h is very much deprecated...

@serhiy-katsyuba-intel serhiy-katsyuba-intel May 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's not used in production code, only in those debug macros. So this did not cause any bug.


/**
* \brief Returns pointer to the memory shared by multiple cores.
Expand Down
Loading