Skip to content

fixup! topology2: Use SAMPLE_TYPE_MSB_INTEGER for ALH copier #8800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Jan 26, 2024
Merged

fixup! topology2: Use SAMPLE_TYPE_MSB_INTEGER for ALH copier #8800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/topology/topology2/platform/intel/sdw-amp-generic.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,8 @@ IncludeByKey.SDW_AMP_FEEDBACK {
in_valid_bit_depth 32
in_ch_cfg $CHANNEL_CONFIG_3_POINT_1
in_ch_map $CHANNEL_MAP_3_POINT_1
in_sample_type $SAMPLE_TYPE_MSB_INTEGER
in_fmt_cfg "$[($in_channels | ($in_valid_bit_depth * 256))]"
}
]
Object.Base.output_audio_format [
Expand All @@ -461,6 +463,8 @@ IncludeByKey.SDW_AMP_FEEDBACK {
out_valid_bit_depth 32
out_ch_cfg $CHANNEL_CONFIG_3_POINT_1
out_ch_map $CHANNEL_MAP_3_POINT_1
out_sample_type $SAMPLE_TYPE_MSB_INTEGER
out_fmt_cfg "$[($out_channels | ($out_valid_bit_depth * 256))]"

@kv2019i kv2019i Jan 26, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have no practical impact given out_valid_bit_depth is 32. The bit-alignment only takes effect when valid-bits is smaller than the container size.

@bardliao bardliao Jan 26, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have no practical impact given out_valid_bit_depth is 32. The bit-alignment only takes effect when valid-bits is smaller than the container size.

Right, but it is better to be consistent. Other ALH dais set SAMPLE_TYPE_MSB_INTEGER no matter the valid_bit_depth is 32 bit or not. :)

}
]
}
Expand Down