Skip to content

topology2: common: pcm_caps: Change the periods_max from 1024 to 256#9204

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
ujfalusi:peter/pr/lower-the-periods-max-01
Jun 14, 2024
Merged

topology2: common: pcm_caps: Change the periods_max from 1024 to 256#9204
kv2019i merged 1 commit into
thesofproject:mainfrom
ujfalusi:peter/pr/lower-the-periods-max-01

Conversation

@ujfalusi

@ujfalusi ujfalusi commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

HDA host DMA has limitation on the number of BDL entries which translates to number of periods, this limit is 256.

The Chrome ALSA compliance test is eagerly try to use as many periods as it can which exceeds the BDL limit and the stream cannot be started.

Fixes: b3a6d1c ("topology2: common: pcm_caps: Increase periods_max from 16 to 1024")

@ujfalusi

ujfalusi commented Jun 6, 2024

Copy link
Copy Markdown
Contributor Author

@kv2019i, this is a candidate to backport for stable branches.

Comment thread tools/topology/topology2/include/common/pcm_caps.conf Outdated
HDA host DMA has limitation on the number of BDL entries which translates
to number of periods, this limit is 256.

The Chrome ALSA compliance test is eagerly try to use as many periods as
it can which exceeds the BDL limit and the stream cannot be started.

Fixes: b3a6d1c ("topology2: common: pcm_caps: Increase periods_max from 16 to 1024")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
@ujfalusi

ujfalusi commented Jun 7, 2024

Copy link
Copy Markdown
Contributor Author

Changes since v1:

  • fixed off by one (255 -> 256 max periods)

@ujfalusi ujfalusi changed the title topology2: common: pcm_caps: Change the periods_max from 1024 to 255 topology2: common: pcm_caps: Change the periods_max from 1024 to 256 Jun 7, 2024
@ujfalusi ujfalusi force-pushed the peter/pr/lower-the-periods-max-01 branch from 9c2175b to 42f61df Compare June 7, 2024 05:56
@lgirdwood lgirdwood added this to the v2.10 milestone Jun 7, 2024
@lgirdwood

Copy link
Copy Markdown
Member

@plbossart good now ?

@lgirdwood

Copy link
Copy Markdown
Member

SOFCI TEST

@kv2019i kv2019i merged commit e137e9b into thesofproject:main Jun 14, 2024
@ujfalusi ujfalusi deleted the peter/pr/lower-the-periods-max-01 branch March 20, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants