Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

Add support for remote Tidal backends#28

Merged
thgrund merged 4 commits into
thgrund:developfrom
virtualdxs:develop
May 27, 2026
Merged

Add support for remote Tidal backends#28
thgrund merged 4 commits into
thgrund:developfrom
virtualdxs:develop

Conversation

@virtualdxs

Copy link
Copy Markdown

Allow communication with Tidal over a unix socket, with a design easily extensible to add other backends such as TCP. This allows for a multi-editor setup via a broker that manages the GHCi process.

@thgrund thgrund left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea! Could you please add a comment in the README.md for this feature? And please fix the failing unit tests.

Comment thread lua/tidal/core/boot.lua Outdated
Comment thread lua/tidal/highlighting/tokenizer.lua
@virtualdxs

Copy link
Copy Markdown
Author

Pushed a fix for the tokenizer test. The other 3 are preexisting on develop, but only show up on nvim v13 nightly. Seems to be caused by uv being stubbed out and nvim v13 trying to call an hrtime function not defined in the stub.

@virtualdxs virtualdxs requested a review from thgrund May 22, 2026 16:36
@thgrund

thgrund commented May 26, 2026

Copy link
Copy Markdown
Owner

Pushed a fix for the tokenizer test. The other 3 are preexisting on develop, but only show up on nvim v13 nightly. Seems to be caused by uv being stubbed out and nvim v13 trying to call an hrtime function not defined in the stub.

Please rebase this PR. I fixed the pipeline issue here: #31
In fact I prefer to use the stable tag instead of the nightly build. And it's the version that I use on my local machine anyway.

@thgrund thgrund left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution.

Still would be nice, if you could add this feature in the README.

@virtualdxs

Copy link
Copy Markdown
Author

I believe I already added it to the README? Rebasing now

Allow communication with Tidal over a unix socket, with a design easily
extensible to add other backends such as TCP. This allows for a
multi-editor setup via a broker that manages the GHCi process.
@virtualdxs

Copy link
Copy Markdown
Author

Rebased, and make test passes locally.

@thgrund

thgrund commented May 27, 2026

Copy link
Copy Markdown
Owner

I believe I already added it to the README? Rebasing now

You are totally right! I will merge it now. Thanks for the contribution :-)

@thgrund thgrund merged commit dd5d723 into thgrund:develop May 27, 2026
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants