Skip to content

Fix main device type and name updates #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilbersl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix main device type and name updates #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63ba172
Catch edgecase, don't try to register "main" as a child device
wilbersl Mar 19, 2026
f4f767f
Bugfix, assign topic for all device names
wilbersl Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions tedge_modbus/reader/reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,16 +622,21 @@ def register_service(self):
def register_child_devices(self, devices):
"""Register the child devices with thin-edge.io"""
for device in devices:
self.logger.debug("Child device registration for device %s", device["name"])
topic = f"te/device/{device['name']}//"
payload = {
"@type": "child-device",
"name": device["name"],
"type": "modbus-device",
}
self.send_tedge_message(
MappedMessage(json.dumps(payload), topic), retain=True, qos=1
)
if device["name"] != "main":
self.logger.debug(
"Child device registration for device %s", device["name"]
)
payload = {
"@type": "child-device",
"name": device["name"],
"type": "modbus-device",
}
self.send_tedge_message(
MappedMessage(json.dumps(payload), topic), retain=True, qos=1
)

self.logger.debug("Set command registration for device %s", device["name"])
cmd_payload = "{}"
for cmd in ["modbus_SetRegister", "modbus_SetCoil"]:
cmd_topic = topic + f"/cmd/{cmd}"
Expand Down
Loading