Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 16, 2026


PR-Codex overview

This PR focuses on adding support for the wallet_getCallsStatusRaw method across various wallet implementations, enhancing the functionality for retrieving raw call statuses in compliance with EIP-5792.

Detailed summary

  • Introduced getCallsStatusRaw method in several wallet files.
  • Updated getCallsStatus calls to getCallsStatusRaw where applicable.
  • Enhanced error handling for unsupported wallets in getCallsStatusRaw.
  • Added documentation for getCallsStatusRaw in type definitions.
  • Implemented inAppWalletGetCallsStatusRaw function for retrieving call statuses.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Fixed getCallStatus to work correctly with EIP1193 provider implementations.
  • New Features

    • Added getCallsStatusRaw method to wallet accounts for direct access to raw transaction call status responses.
  • Updates

    • Updated demo application to use latest wagmi utilities and enhanced utility functions.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs-v2 Ready Ready Preview, Comment Jan 16, 2026 1:30am
nebula Ready Ready Preview, Comment Jan 16, 2026 1:30am
thirdweb_playground Ready Ready Preview, Comment Jan 16, 2026 1:30am
thirdweb-www Ready Ready Preview, Comment Jan 16, 2026 1:30am
wallet-ui Ready Ready Preview, Comment Jan 16, 2026 1:30am

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2026

🦋 Changeset detected

Latest commit: 3b14e6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch
wagmi-inapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This PR introduces a getCallsStatusRaw method across multiple wallet implementations to return raw transaction call status responses. It adds the GetCallsStatusRawResponse type, implements raw status fetching for Coinbase, in-app, injected, and smart accounts, updates the EIP1193 adapter to use the raw variant, and updates the wagmi-demo to use useWaitForCallsStatus.

Changes

Cohort / File(s) Summary
Release Metadata
.changeset/yummy-sloths-live.md
Adds patch changeset documenting fix for getCallStatus with EIP1193 provider support.
Demo Application
apps/wagmi-demo/src/App.tsx
Replaces useCallsStatus with useWaitForCallsStatus from wagmi; switches address rendering from JSON.stringify to stringify from thirdweb/utils; expands second call object to include data: "0x1234".
Core Adapter
packages/thirdweb/src/adapters/eip1193/to-eip1193.ts
Replaces account.getCallsStatus with account.getCallsStatusRaw, adds await and result variable storage, updates pre-check to validate getCallsStatusRaw presence.
Wallet Interface
packages/thirdweb/src/wallets/interfaces/wallet.ts
Adds import of GetCallsStatusRawResponse type; adds optional getCallsStatusRaw(options) method to Account interface.
Coinbase Wallet
packages/thirdweb/src/wallets/coinbase/coinbase-web.ts
Adds new public method getCallsStatusRaw(options) that returns raw GetCallsStatusRawResponse from wallet provider with identical error handling.
In-App Wallet Core
packages/thirdweb/src/wallets/in-app/core/eip5792/in-app-wallet-calls.ts
Introduces inAppWalletGetCallsStatusRaw function to fetch transaction receipts per bundle, aggregate blockHash/blockNumber/gasUsed/logs, derive status ("0x1" or "0x0"), and return structured GetCallsStatusRawResponse.
In-App Wallet Wrappers
packages/thirdweb/src/wallets/in-app/core/eip7702/minimal-account.ts, packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts
Each adds public method getCallsStatusRaw(options) with dynamic import of inAppWalletGetCallsStatusRaw and delegation to it.
Injected Wallets
packages/thirdweb/src/wallets/injected/index.ts
Adds public method getCallsStatusRaw(options) that calls wallet_getCallsStatus directly and returns raw GetCallsStatusRawResponse with identical error handling to getCallsStatus.
Smart Accounts
packages/thirdweb/src/wallets/smart/index.ts
Adds getCallsStatusRaw(options) method to both createSmartAccount and createZkSyncAccount Account objects, delegating via dynamic import to inAppWalletGetCallsStatusRaw.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a3ea002 and 3b14e6f.

📒 Files selected for processing (10)
  • .changeset/yummy-sloths-live.md
  • apps/wagmi-demo/src/App.tsx
  • packages/thirdweb/src/adapters/eip1193/to-eip1193.ts
  • packages/thirdweb/src/wallets/coinbase/coinbase-web.ts
  • packages/thirdweb/src/wallets/in-app/core/eip5792/in-app-wallet-calls.ts
  • packages/thirdweb/src/wallets/in-app/core/eip7702/minimal-account.ts
  • packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts
  • packages/thirdweb/src/wallets/injected/index.ts
  • packages/thirdweb/src/wallets/interfaces/wallet.ts
  • packages/thirdweb/src/wallets/smart/index.ts

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 16, 2026
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review January 16, 2026 01:18
@joaquim-verges joaquim-verges requested review from a team as code owners January 16, 2026 01:18
@joaquim-verges joaquim-verges merged commit d38deec into main Jan 16, 2026
20 of 24 checks passed
@joaquim-verges joaquim-verges deleted the Fix_getCallStatus_via_EIP1193_provider branch January 16, 2026 01:20
@joaquim-verges joaquim-verges mentioned this pull request Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 8.47458% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.01%. Comparing base (a3ea002) to head (3b14e6f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/thirdweb/src/wallets/coinbase/coinbase-web.ts 6.25% 15 Missing ⚠️
packages/thirdweb/src/wallets/injected/index.ts 6.25% 15 Missing ⚠️
packages/thirdweb/src/wallets/smart/index.ts 8.33% 11 Missing ⚠️
...src/wallets/in-app/core/eip7702/minimal-account.ts 16.66% 5 Missing ⚠️
...b/src/wallets/in-app/core/wallet/enclave-wallet.ts 16.66% 5 Missing ⚠️
...ckages/thirdweb/src/adapters/eip1193/to-eip1193.ts 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (8.47%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8639      +/-   ##
==========================================
- Coverage   53.06%   53.01%   -0.05%     
==========================================
  Files         932      932              
  Lines       62298    62355      +57     
  Branches     4104     4104              
==========================================
  Hits        33057    33057              
- Misses      29142    29199      +57     
  Partials       99       99              
Flag Coverage Δ
packages 53.01% <8.47%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
...ckages/thirdweb/src/adapters/eip1193/to-eip1193.ts 50.31% <0.00%> (-0.32%) ⬇️
...src/wallets/in-app/core/eip7702/minimal-account.ts 88.38% <16.66%> (-0.49%) ⬇️
...b/src/wallets/in-app/core/wallet/enclave-wallet.ts 39.59% <16.66%> (-0.58%) ⬇️
packages/thirdweb/src/wallets/smart/index.ts 37.27% <8.33%> (-0.63%) ⬇️
...ages/thirdweb/src/wallets/coinbase/coinbase-web.ts 32.66% <6.25%> (-1.27%) ⬇️
packages/thirdweb/src/wallets/injected/index.ts 30.02% <6.25%> (-0.94%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants