Minor refactoring and code cleanup#28
Merged
thisisparker merged 1 commit intothisisparker:masterfrom Apr 21, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some superficial cleanup I did while familiarizing myself with the code:
Use a translation table instead of
small_nums()andencircle()(seestr.maketrans()andstr.translate()).Take out some extraneous
return Nones for functions that aren't expected to return a valueTighten up some boolean logic
I realized only after finishing this PR that it duplicates some of the work over in #27, but maybe this will make that PR more contained to the terminal resizing work. 🙂