fix regression in panic_misaligned_pointer_dereference#1
Closed
thomasdangl wants to merge 1 commit intomasterfrom
Closed
fix regression in panic_misaligned_pointer_dereference#1thomasdangl wants to merge 1 commit intomasterfrom
thomasdangl wants to merge 1 commit intomasterfrom
Conversation
…th panic_immediate_abort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang#118362 introduced a regression that breaks pointer dereferencing in
core.Until 8de5bd0 this worked totally fine.
However, since the commit ended up in master, the linker is quite unhappy about the symbol:
Is there a specific reason
panic_misaligned_pointer_dereferenceis supposed to be inlined?Otherwise I suggest we just avoid inlining it for
panic_immediate_abort.Perhaps this is also something to be added as an example for rust-lang#118393.
Best,
Thomas