Skip to content

feat: Add pagination iterable helper#125

Merged
rodrirod-te merged 1 commit intomainfrom
CP-2451
Jan 26, 2026
Merged

feat: Add pagination iterable helper#125
rodrirod-te merged 1 commit intomainfrom
CP-2451

Conversation

@rodrirod-te
Copy link
Contributor

@rodrirod-te rodrirod-te commented Jan 16, 2026

Implement an iterator that abstracts pagination for the user. Follows the approach for the java sdk

@rodrirod-te rodrirod-te requested a review from a team January 16, 2026 17:11
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
66526 44253 67% 40% 🟢

New Files

File Coverage Status
thousandeyes-sdk-core/src/thousandeyes_sdk/core/pagination_iterable.py 92% 🟢
thousandeyes-sdk-core/test/test_pagination_iterable.py 96% 🟢
TOTAL 94% 🟢

Modified Files

File Coverage Status
thousandeyes-sdk-core/src/thousandeyes_sdk/core/init.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 7b833c5 by action🐍

@goncarva-te
Copy link

☂️ Python Coverage

current status: ❌

Overall Coverage

Lines Covered Coverage Threshold Status
66471 44165 66% 40% 🟢

New Files

File Coverage Status
thousandeyes-sdk-core/src/thousandeyes_sdk/core/iterable.py 15% 🔴
TOTAL 15% 🔴

Modified Files

File Coverage Status
thousandeyes-sdk-core/src/thousandeyes_sdk/core/init.py 100% 🟢
TOTAL 100% 🟢

updated for commit: ca3dd7c by action🐍

Nice work @rodrirod-te, could you just take a look at this?

@rodrirod-te
Copy link
Contributor Author

☂️ Python Coverage

current status: ❌

Overall Coverage

Lines Covered Coverage Threshold Status
66471 44165 66% 40% 🟢

New Files

File Coverage Status
thousandeyes-sdk-core/src/thousandeyes_sdk/core/iterable.py 15% 🔴
TOTAL 15% 🔴

Modified Files

File Coverage Status
thousandeyes-sdk-core/src/thousandeyes_sdk/core/init.py 100% 🟢
TOTAL 100% 🟢

updated for commit: ca3dd7c by action🐍

Nice work @rodrirod-te, could you just take a look at this?

This is an example of an approach for the pagination spike, so it is unfinished and i didn't add any tests yet.
I am just checking what you think of the approach

@rodrirod-te rodrirod-te requested review from a team and jabrowne-te January 20, 2026 17:45
@rodrirod-te rodrirod-te changed the title CP-2451 Add paginator iterator helper feat: Add paginator iterator helper Jan 21, 2026
@rodrirod-te rodrirod-te changed the title feat: Add paginator iterator helper CP-2320: Add paginator iterator helper Jan 23, 2026
Copy link
Contributor

@jabrowne-te jabrowne-te left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this change looks good to me.

But, one other thing, for the Java SDK we actually added methods that wrapped the API operations and directly returned the relevant Iterator (example), so I guess we should do that here too? Can be a follow up PR though as that will be on the generator side

@jabrowne-te
Copy link
Contributor

jabrowne-te commented Jan 23, 2026

Please update the PR title to feat: Add paginator iterator helper as this is a public repo — ideally the commit messages too

@rodrirod-te rodrirod-te changed the title CP-2320: Add paginator iterator helper CP-2320: Add pagination iterable helper Jan 26, 2026
@rodrirod-te rodrirod-te changed the title CP-2320: Add pagination iterable helper feat: Add pagination iterable helper Jan 26, 2026
@rodrirod-te
Copy link
Contributor Author

Overall, this change looks good to me.

But, one other thing, for the Java SDK we actually added methods that wrapped the API operations and directly returned the relevant Iterator (example), so I guess we should do that here too? Can be a follow up PR though as that will be on the generator side

I will create a second PR. Thanks!

@rodrirod-te rodrirod-te requested a review from a team January 26, 2026 09:26
@rodrirod-te rodrirod-te merged commit 85758d8 into main Jan 26, 2026
1 check passed
@rodrirod-te rodrirod-te deleted the CP-2451 branch January 26, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments