You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice work @rodrirod-te, could you just take a look at this?
This is an example of an approach for the pagination spike, so it is unfinished and i didn't add any tests yet.
I am just checking what you think of the approach
The reason will be displayed to describe this comment to others. Learn more.
Overall, this change looks good to me.
But, one other thing, for the Java SDK we actually added methods that wrapped the API operations and directly returned the relevant Iterator (example), so I guess we should do that here too? Can be a follow up PR though as that will be on the generator side
But, one other thing, for the Java SDK we actually added methods that wrapped the API operations and directly returned the relevant Iterator (example), so I guess we should do that here too? Can be a follow up PR though as that will be on the generator side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement an iterator that abstracts pagination for the user. Follows the approach for the java sdk