Skip to content

Add browser_path option for browser jobs#861

Open
Matt-Deacalion wants to merge 1 commit intothp:masterfrom
Matt-Deacalion:master
Open

Add browser_path option for browser jobs#861
Matt-Deacalion wants to merge 1 commit intothp:masterfrom
Matt-Deacalion:master

Conversation

@Matt-Deacalion
Copy link
Contributor

Allow specifying a browser executable for Playwright instead of the bundled browser.

The option can be set per job or globally via job_defaults in urlwatch.yaml, and supports system-installed browsers or custom builds.

Allow specifying a browser executable for Playwright instead of the bundled browser.

The option can be set per job or globally via job_defaults in urlwatch.yaml, and supports system-installed browsers or custom builds.
Copy link
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the manpage changes and the mode change on update-manpages.sh. The manpages are usually updated in one go during release.

As for the name of the key, what about browser_executable, or browser_executable_path? It more closely matches what playwright takes as a parameter, and doesn't confuse with the concept of "path" as in e.g. search path ($PATH and otherwise).

I'm not ure about the urlwatch.yaml example and the addition to urls.yaml, it feels like this would be more discoverable if there was an advanced topic in docs/source/advanced.rst that describes how to fully use that feature (including per job or globally) and which browser (or browser families) are supported. E.g. does it work with Firefox and derivatives? Chrome and derivatives? Any other browsers? Distro-installed vs Flatpak vs ... (probably fine to just link to the Playwright documentation for this, if there is any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants