Add browser_path option for browser jobs#861
Add browser_path option for browser jobs#861Matt-Deacalion wants to merge 1 commit intothp:masterfrom
Conversation
9ad3d1b to
20d208b
Compare
Allow specifying a browser executable for Playwright instead of the bundled browser. The option can be set per job or globally via job_defaults in urlwatch.yaml, and supports system-installed browsers or custom builds.
20d208b to
6abea29
Compare
thp
left a comment
There was a problem hiding this comment.
Please revert the manpage changes and the mode change on update-manpages.sh. The manpages are usually updated in one go during release.
As for the name of the key, what about browser_executable, or browser_executable_path? It more closely matches what playwright takes as a parameter, and doesn't confuse with the concept of "path" as in e.g. search path ($PATH and otherwise).
I'm not ure about the urlwatch.yaml example and the addition to urls.yaml, it feels like this would be more discoverable if there was an advanced topic in docs/source/advanced.rst that describes how to fully use that feature (including per job or globally) and which browser (or browser families) are supported. E.g. does it work with Firefox and derivatives? Chrome and derivatives? Any other browsers? Distro-installed vs Flatpak vs ... (probably fine to just link to the Playwright documentation for this, if there is any.
Allow specifying a browser executable for Playwright instead of the bundled browser.
The option can be set per job or globally via job_defaults in urlwatch.yaml, and supports system-installed browsers or custom builds.