Handle ERB tag immediately before closing bracket#91
Open
averydev wants to merge 3 commits into
Open
Conversation
Covers edge case where <option value="<%= x %>"> inside an each loop is followed by a div with ERB before closing bracket (%>>).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an ERB tag immediately precedes the closing bracket of an HTML tag (e.g.,
<option <%= "selected" if x %>>), theopen_elementregex failed to match because[^/]>requires a character between%>and>.Changed
[^/]>to(?:%>|[^/])>to allow either%>or a non-/character before the final>.Before: Multi-line tags with ERB conditional attributes would cause incorrect indentation of subsequent elements.
After: Indentation is preserved correctly.