Skip to content

🎨 Palette: Add accessible labels to graph tab icon buttons #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
threehymns wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Add accessible labels to graph tab icon buttons #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

## 2024-05-01 - Adding ARIA labels to Icon-Only Buttons
**Learning:** Found multiple icon-only buttons in the Graph Controls panel (Reset settings, Close panel, Delete group) that lacked `aria-label` attributes, relying solely on `title` or visual cues. This makes them inaccessible to screen reader users who need explicit labels for interactive elements.
**Action:** Always include an `aria-label` attribute alongside the `title` attribute for icon-only `<Button>` components to ensure both visual hover tooltips and screen reader accessibility are supported.
4 changes: 4 additions & 0 deletions src/components/graph-tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,6 +1319,7 @@ interface ForceGraphInstance {
variant="ghost"
size="icon"
title="Reset settings"
aria-label="Reset settings"
onClick={() => setPanel(DEFAULT_PANEL)}
className="size-7"
>
Expand All @@ -1328,6 +1329,7 @@ interface ForceGraphInstance {
variant="ghost"
size="icon"
title="Close panel"
aria-label="Close panel"
onClick={() => setPaneOpen(false)}
className="size-7"
>
Expand Down Expand Up @@ -1431,6 +1433,8 @@ interface ForceGraphInstance {
<Button
variant="ghost"
size="icon"
title="Delete group"
aria-label="Delete group"
onClick={() => {
const next = panel.groups.filter(
(_, i) => i !== index,
Expand Down