Improve draft logic and enable draft resume on startup#2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR improves on the existing draft logic and enables drafts to be resumed at startup when Thunder is killed. Additionally, some of the draft logic was re-worked and consolidated:
active,accountId,nsfw,languageId). Theactivefield indicates the draft that is currently being edited and is used to restore the draft on startupDraftRepositoryto move and consolidate database-related logicFor the create post/comment pages, the old draft timer logic was also replaced with a debounce logic. Additionally, Thunder should now save the draft state when the
AppLifecycleStatechanges (e.g., when Thunder is backgrounded). These two changes should help reduce cases of lost in-progress work.Issue Being Fixed
Issue Number: #2050
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?