feat(THU-616): explain why opposite-mode models are disabled in selector#1007
Open
raivieiraadriano92 wants to merge 1 commit into
Conversation
Semgrep Security ScanNo security issues found. |
raivieiraadriano92
temporarily deployed
to
preview
GitHub Actions
Inactive
|
Preview environment deployed 🚀
Stack: Auto-destroys on PR close/merge. Login via the bundled Keycloak realm — |
PR Metrics
Updated Thu, 18 Jun 2026 21:45:03 GMT · run #1957 |
raivieiraadriano92
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A chat is locked to its confidentiality mode, so the opposite-mode models appear greyed out in the model selector with no explanation. Adds a header + helper text above the disabled bucket — Standard Models / Not available in confidential chats. and Confidential Models / Available only in confidential chats. — using the
label+subtitleslotSearchableMenualready renders for groups.Fixes THU-616.
Note
Low Risk
Copy-only UI grouping in the model selector; no selection logic or backend changes.
Overview
Greyed-out models in the model selector now show why they can’t be selected, instead of appearing in a silent disabled bucket.
categorizeModelssetslabelandsubtitleon the encryption-mismatch groups: Standard Models with Not available in confidential chats. in confidential chats, and Confidential Models with Available only in confidential chats. in standard chats.SearchableMenualready renders those group fields; tests were updated to match.Reviewed by Cursor Bugbot for commit 7ddc07a. Bugbot is set up for automated code reviews on this repo. Configure here.