ci: guard against reachable glib VariantStrIter unsoundness#997
Open
ital0 wants to merge 2 commits into
Open
Conversation
Semgrep Security ScanNo security issues found. |
|
Preview environment deployed 🚀
Stack: Auto-destroys on PR close/merge. Login via the bundled Keycloak realm — |
PR Metrics
Updated Thu, 18 Jun 2026 21:14:53 GMT · run #1950 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4f6c1ff. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
CI-only static check with no application or runtime behavior changes; it reduces risk by catching new callers of an accepted transitive vulnerability.
Overview
Adds a security tripwire for GHSA-wrw7-89jp-8q8g / RUSTSEC-2024-0429 (
glib::VariantStrIterunsoundness on Linux). The team accepts the vulnerableglib0.18.x transitively from Tauri/gtk only while that API stays unreachable.New script
scripts/check-glib-variantstriter.shresolves the locked Linuxsrc-tauridependency graph viacargo metadata, then grepssrc-tauri/srcand every registry crate source (excluding theglibcrate itself) forarray_iter_strorVariantStrIter. It aborts on metadata/jq failures, empty dependency resolution, or grep errors so CI cannot silently pass without scanning.The rust job in
.github/workflows/ci.ymlruns this step before the cargo build (metadata + grep only, no compile).Reviewed by Cursor Bugbot for commit 55a6b80. Bugbot is set up for automated code reviews on this repo. Configure here.