Skip to content

Add macOS workspace CLI support#10

Merged
Zhihaoi merged 4 commits into
thustorage:mainfrom
yzim:feat/macos-workspace-cli
Jun 17, 2026
Merged

Add macOS workspace CLI support#10
Zhihaoi merged 4 commits into
thustorage:mainfrom
yzim:feat/macos-workspace-cli

Conversation

@yzim

@yzim yzim commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR adds agentvfs workspace ... support on macOS and wires the macOS build to include the shared workspace CLI implementation.

Changes

  • dispatch agentvfs workspace from the macOS entrypoint
  • link src/cas/workspace_cli.cpp into the macOS agentvfs target
  • make shared workspace lifecycle helpers work on macOS
  • allow the macOS daemon parser to accept both --sock and --control-sock
  • keep shared workspace spawning aligned with the Linux-style --control-sock flag
  • add a macOS workspace CLI system test under tests/system/macos/test_workspace_cli.sh
  • run the new macOS workspace CLI test in CI alongside the existing direct-mount macOS test

Notes

  • Linux/shared workspace code uses --control-sock
  • existing direct macOS usage/help still shows --sock but --control-sock is added to align with Linux code.
  • this PR keeps macOS compatible with both forms so workspace flows work without changing the shared caller
  • the macOS workspace test is placed under the dedicated tests/system/macos/ directory; broader test-directory refactoring is split into a separate PR

@yzim yzim marked this pull request as ready for review June 16, 2026 14:43
@Zhihaoi

Zhihaoi commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

LGTM. Thanks.

@Zhihaoi Zhihaoi merged commit 7489aad into thustorage:main Jun 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants