fix: composer keyboard behavior and allow sending while agent is running#422
Merged
tiann merged 1 commit intotiann:mainfrom Apr 9, 2026
Merged
Conversation
Contributor
mrrnb
commented
Apr 9, 2026
mrrnb
commented
- Enter no longer inserts newline when sending is blocked (no-op instead)
- Shift+Enter now inserts newline (standard convention)
- Allow appending messages while agent is running (remove threadIsRunning gate from canSend) — matches Claude Code CLI behavior where users can queue messages during execution
- Enter no longer inserts newline when sending is blocked (no-op instead) - Shift+Enter now inserts newline (standard convention) - Allow appending messages while agent is running (remove threadIsRunning gate from canSend) — matches Claude Code CLI behavior where users can queue messages during execution
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings
- No actionable issues found in the added/modified lines.
Summary
- Review mode: initial
- No diff-attributed correctness, security, or regression issues found.
- Residual risk:
web/src/components/AssistantChat/HappyComposer.tsxstill has no focused keyboard-behavior test coverage for Enter/Shift+Enter or send-while-running.
Testing
- Not run (automation environment missing
bun). Existing web tests do not appear to coverHappyComposerkeyboard behavior.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.