Exposing S3 connector#25
Closed
dotfelix wants to merge 3 commits into
Closed
Conversation
Member
|
Looks good, running workflows. |
Member
|
@dotfelix your DCO compliance is failing, you can accept it over web ui. With that once all is green I'm ok to merge. Do let me know. Cheers |
Member
|
Looks like minor refact need to open on desktop. Was the code tested locally and under what environment? Potentially will help trace cause |
Contributor
Author
Aside from running test, I linked it into my project for s3 connector |
Signed-off-by: KB <dotfelixb@gmail.com>
Member
|
@dotfelix DCO is not accepted it seems, workflows pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exposing S3 connector for native tidesdb_objstore_s3_create