Skip to content

feat(ios): reviving PR #12411 for ios background tasks#14142

Open
AbdullahFaqeir wants to merge 9 commits into
tidev:mainfrom
AbdullahFaqeir:ios-background-tasks
Open

feat(ios): reviving PR #12411 for ios background tasks#14142
AbdullahFaqeir wants to merge 9 commits into
tidev:mainfrom
AbdullahFaqeir:ios-background-tasks

Conversation

@AbdullahFaqeir
Copy link
Copy Markdown
Contributor

@AbdullahFaqeir AbdullahFaqeir commented Nov 9, 2024

This PR is solely to revive PR #12411

@AbdullahFaqeir AbdullahFaqeir changed the title feat(ios): reviving PR (#12411) for ios background tasks feat(ios): reviving PR #12411 for ios background tasks Nov 9, 2024
Comment thread iphone/iphone/Assets.xcassets/AppIcon.appiconset/Contents.json
@AbdullahFaqeir
Copy link
Copy Markdown
Contributor Author

@hansemannn @m1ga if we can check this

@m1ga
Copy link
Copy Markdown
Contributor

m1ga commented Nov 12, 2024

@AbdullahFaqeir I think you are still on a different branch as I can see some of your "ios dark mode icons" stuff in there.

@AbdullahFaqeir
Copy link
Copy Markdown
Contributor Author

@AbdullahFaqeir I think you are still on a different branch as I can see some of your "ios dark mode icons" stuff in there.

@m1ga already cleaned up

@m1ga
Copy link
Copy Markdown
Contributor

m1ga commented Nov 12, 2024

@AbdullahFaqeir
Copy link
Copy Markdown
Contributor Author

I only reverted the file to it's original content from the main repo

@m1ga
Copy link
Copy Markdown
Contributor

m1ga commented Nov 12, 2024

That part (and the other file you reverted already) is from your other PR: https://github.com/tidev/titanium-sdk/pull/14137/files . It looks like you didn't start from the master branch to start the PR but from this branch ios-dark-mode-icons

Copy link
Copy Markdown
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some open issues before we can proceed, but it looks good in general!

Comment thread iphone/Classes/TiAppiOSProxy.m
Comment thread iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Comment thread iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Comment thread iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Comment thread iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Comment thread iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Comment thread iphone/iphone/Assets.xcassets/AppIcon.appiconset/Contents.json
Comment thread iphone/iphone/Titanium.xcodeproj/project.pbxproj
Comment thread iphone/iphone/Titanium.xcodeproj/project.pbxproj
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedliveview@​1.5.6721009984100
Addedlodash.merge@​4.6.21001007775100
Addedmarkdown@​0.5.010010010075100
Addednodeify@​1.0.11001009675100
Addednpm-run-all@​4.1.5991009875100
Addednode-titanium-sdk@​6.1.0771007687100
Addednode-appc@​1.1.7781008783100
Addedlockfile-lint@​4.14.19910010083100
Addednyc@​17.1.09710010084100
Addedmoment@​2.30.11001009185100
Addedmocha@​11.7.4971009595100
Addedlint-staged@​16.2.59910010096100

View full report

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: Prototype Pollution in npm minimist

CVE: GHSA-xvch-5gv4-984h Prototype Pollution in minimist (CRITICAL)

Affected versions: >= 1.0.0 < 1.2.6; < 0.2.4

Patched version: 0.2.4

From: package-lock.jsonnpm/liveview@1.5.6npm/minimist@0.0.10

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/minimist@0.0.10. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
Critical CVE: npm xmldom allows multiple root nodes in a DOM

CVE: GHSA-crh6-fp67-6883 xmldom allows multiple root nodes in a DOM (CRITICAL)

Affected versions: <= 0.6.0

Patched version: No patched versions

From: package-lock.jsonnpm/liveview@1.5.6npm/xmldom@0.1.27

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/xmldom@0.1.27. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm jiti is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: package-lock.jsonnpm/cz-conventional-changelog@3.3.0npm/@commitlint/cli@20.1.0npm/jiti@2.6.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/jiti@2.6.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm json-schema is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: package-lock.jsonnpm/json-schema@0.4.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/json-schema@0.4.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@AbdullahFaqeir
Copy link
Copy Markdown
Contributor Author

@hansemannn @m1ga FIY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants