fix(ios): fix containment issues once and for all by hansemannn · Pull Request #14397 · tidev/titanium-sdk

hansemannn · 2026-02-23T20:57:45Z

A follow-up of #14261 with a more focussed approach of recognizing different containment references and comparing them. Also fixing this (related) issue:

  Calling -viewDidAppear: directly on a view controller is not supported, and may result in out-of-order callbacks and other inconsistent behavior. Use the -beginAppearanceTransition:animated: and -endAppearanceTransition APIs on          
  UIViewController to manually drive appearance callbacks instead. Make a symbolic breakpoint at UIViewControllerAlertForAppearanceCallbackMisuse to catch this in the debugger. View controller: <UINavigationController: 0x105833000>

hansemannn · 2026-02-23T20:58:38Z

Hey @designbymind, would you mind giving this one a shot? As the other one broke your setup and was reproducible, this one should either also crash or work :)

designbymind · 2026-02-25T03:02:28Z

Hey @hansemannn, I've tried building with these latest commits but I'm still getting back the error below. Just to add some additional context here, I am attempting to add a Ti TabGroup to the center window of a drawer instance (by using a version of this module).

Error

Last Exception Backtrace:
0   CoreFoundation                	       0x10bca01c4 __exceptionPreprocess + 160
1   libobjc.A.dylib               	       0x105580094 objc_exception_throw + 72
2   CoreFoundation                	       0x10bca00e0 -[NSException initWithCoder:] + 0
3   UIKitCore                     	       0x1548646a0 -[UIView(Hierarchy) _associatedViewControllerForwardsAppearanceCallbacks:performHierarchyCheck:isRoot:] + 216
4   UIKitCore                     	       0x154864e60 -[UIView(Hierarchy) _willMoveToWindow:withAncestorView:] + 184
5   UIKitCore                     	       0x1548728b8 -[UIView(Internal) _addSubview:positioned:relativeTo:] + 368
6   AppName                      	       0x104aef2f8 __21-[TiUITabGroup open:]_block_invoke + 240 (TiUITabGroup.m:711)
7   libdispatch.dylib             	       0x10eefd7a8 _dispatch_call_block_and_release + 24
8   libdispatch.dylib             	       0x10ef184b0 _dispatch_client_callout + 12
9   libdispatch.dylib             	       0x10ef344a0 <deduplicated_symbol> + 24
10  libdispatch.dylib             	       0x10ef0d31c _dispatch_main_queue_drain + 1184
11  libdispatch.dylib             	       0x10ef0ce6c _dispatch_main_queue_callback_4CF + 40
12  CoreFoundation                	       0x10bbfeed8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
13  CoreFoundation                	       0x10bbfe0b0 __CFRunLoopRun + 1884
14  CoreFoundation                	       0x10bbf8cec _CFRunLoopRunSpecificWithOptions + 496
15  GraphicsServices              	       0x11fe729bc GSEventRunModal + 116
16  UIKitCore                     	       0x1542aa574 -[UIApplication _run] + 772
17  UIKitCore                     	       0x1542ae79c UIApplicationMain + 124
18  AppName                      	       0x104af0b44 main + 800 (main.m:70)
19  ???                           	       0x1050e93d0 ???
20  dyld                          	       0x1053d0d54 start + 7184

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x11433c85c __pthread_kill + 8
1   libsystem_pthread.dylib       	       0x11445a2a8 pthread_kill + 264
2   libsystem_c.dylib             	       0x1141d0a0c __abort + 108
3   libsystem_c.dylib             	       0x1141d09a0 abort + 112
4   libc++abi.dylib               	       0x1075c926c __abort_message + 128
5   libc++abi.dylib               	       0x1075b91a4 demangling_terminate_handler() + 268
6   libobjc.A.dylib               	       0x10555b218 _objc_terminate() + 124
7   libc++abi.dylib               	       0x1075c8758 std::__terminate(void (*)()) + 12
8   libc++abi.dylib               	       0x1075cb7c0 __cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32
9   libc++abi.dylib               	       0x1075cb7a0 __cxa_throw + 88
10  libobjc.A.dylib               	       0x1055801cc objc_exception_throw + 384
11  CoreFoundation                	       0x10bca00e0 +[NSException raise:format:] + 124
12  UIKitCore                     	       0x1548646a0 -[UIView(Hierarchy) _associatedViewControllerForwardsAppearanceCallbacks:performHierarchyCheck:isRoot:] + 216
13  UIKitCore                     	       0x154864e60 -[UIView(Hierarchy) _willMoveToWindow:withAncestorView:] + 184
14  UIKitCore                     	       0x1548728b8 -[UIView(Internal) _addSubview:positioned:relativeTo:] + 368
15  AppName                      	       0x104aef2f8 __21-[TiUITabGroup open:]_block_invoke + 240 (TiUITabGroup.m:711)
16  libdispatch.dylib             	       0x10eefd7a8 _dispatch_call_block_and_release + 24
17  libdispatch.dylib             	       0x10ef184b0 _dispatch_client_callout + 12
18  libdispatch.dylib             	       0x10ef344a0 <deduplicated_symbol> + 24
19  libdispatch.dylib             	       0x10ef0d31c _dispatch_main_queue_drain + 1184
20  libdispatch.dylib             	       0x10ef0ce6c _dispatch_main_queue_callback_4CF + 40
21  CoreFoundation                	       0x10bbfeed8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
22  CoreFoundation                	       0x10bbfe0b0 __CFRunLoopRun + 1884
23  CoreFoundation                	       0x10bbf8cec _CFRunLoopRunSpecificWithOptions + 496
24  GraphicsServices              	       0x11fe729bc GSEventRunModal + 116
25  UIKitCore                     	       0x1542aa574 -[UIApplication _run] + 772
26  UIKitCore                     	       0x1542ae79c UIApplicationMain + 124
27  AppName                      	       0x104af0b44 main + 800 (main.m:70)
28  ???                           	       0x1050e93d0 ???
29  dyld                          	       0x1053d0d54 start + 7184

hansemannn · 2026-02-25T07:41:12Z

Ohhh, okay. The drawer module is external and likely needs fixes as well after these fixes in the SDK. Can you peovide a minimal repro?

designbymind · 2026-02-25T16:17:14Z

This should help. It's super minimal, just enough to reproduce. Do you want full GH repo or will this work for testing?

/*
TiSDK: 13.1.0.GA
Required Module:
Link: https://github.com/mbender74/NappDrawer
Include: <module platform="iphone" version="2.2.7">dk.napp.drawer</module>
*/

const NappDrawerModule = require('dk.napp.drawer');

const drawer = NappDrawerModule.createDrawer({
	width: Ti.Platform.displayCaps.platformWidth,
	orientationModes: [Ti.UI.PORTRAIT],
	backgroundColor: '#000000',
	animationMode: NappDrawerModule.ANIMATION_SLIDE,
	closeDrawerGestureMode: NappDrawerModule.CLOSE_MODE_ALL,
	openDrawerGestureMode: NappDrawerModule.OPEN_MODE_NONE,
	shouldStretchDrawer: false,
	showShadow: false,
	animationVelocity: 1300,
	leftDrawerWidth: Ti.Platform.displayCaps.platformWidth,
	rightDrawerWidth: Ti.Platform.displayCaps.platformWidth
});

// Create Drawers
const leftDrawerWindow = Ti.UI.createWindow({
	title: 'Left Drawer',
	backgroundColor: '#FFFFFF'
});

const leftDrawer = Ti.UI.createNavigationWindow({
	window: leftDrawerWindow
});

const rightDrawerWindow = Ti.UI.createWindow({
	title: 'Right Drawer',
	backgroundColor: '#FFFFFF'
});

const rightDrawer = Ti.UI.createNavigationWindow({
	window: rightDrawerWindow
});

const win1 = Ti.UI.createWindow({
	backgroundColor: 'blue',
	title: 'Blue'
});
win1.add(Ti.UI.createLabel({ text: 'I am a blue window.' }));

const win2 = Ti.UI.createWindow({
	backgroundColor: 'red',
	title: 'Red'
});
win2.add(Ti.UI.createLabel({ text: 'I am a red window.' }));

const tab1 = Ti.UI.createTab({
		window: win1,
		title: 'Blue'
	}),
	tab2 = Ti.UI.createTab({
		window: win2,
		title: 'Red'
	}),
	tabGroup = Ti.UI.createTabGroup({
		tabs: [tab1, tab2]
	});

// Open our TabGroup (crashes with or without opening)
// tabGroup.open();

// --- Set drawer Windows ---
drawer.leftWindow = leftDrawer;
drawer.rightWindow = rightDrawer;
drawer.centerWindow = tabGroup;

// Open the drawer
drawer.open();

// Should crash with the error reported at the link below:
// https://github.com/tidev/titanium-sdk/pull/14397#issuecomment-3956428982

designbymind · 2026-02-25T16:24:40Z

Note: The commits made here work with a normal TabGroup implementation on my end (not contained in drawer module). Thought this was worth mentioning...

hansemannn · 2026-03-15T03:39:24Z

@designbymind Which fork of napp-drawer do you use? I will try to fix that module as well

designbymind · 2026-03-16T17:08:29Z

@hansemannn I'm just now seeing your comment. There are quite a few forks, but I'm almost positive that I'm currently using this one. A fix would be really awesome as I'm pretty sure the module is a very popular one, I see it frequently mentioned in TiSlack...

hansemannn · 2026-03-18T08:54:10Z

Can you try dk.napp.drawer-iphone-3.0.0.zip?

designbymind · 2026-03-18T16:09:09Z

Just gave the NappDrawer 3.0.0 module build a try and it's returning the exact same error as above. This is with the commits patched in from this PR. Grrrrr 🤷‍♂️

hansemannn · 2026-03-18T16:42:26Z

Try this one?

dk.napp.drawer-iphone-3.0.0.zip

designbymind · 2026-03-18T18:34:17Z

Hmmm. Same exact error 🫤

hansemannn · 2026-03-18T19:16:56Z

Weird. Exact crash line by line? can you double check it's the right module version?

designbymind · 2026-03-18T19:56:31Z

I just reinstalled the latest 3.0.0, triple-checked module version being used, cleaned project, built again (using the test app above with TiSDK 13.1.1.GA patched with this PR) and am receiving the same error (sent full report via Slack in case of sensitive into in report)...

mbender74 · 2026-05-22T12:41:41Z

@hansemannn @designbymind I will care about NappDrawerModule.... I assume a fix could be related to this issue:
#14021 and this fix: #14450

hansemannn · 2026-05-22T12:49:21Z

@mbender74 Is your PR an alternative to this one or an addition? As I deleted more duplicate code and yours is a rather small change.

mbender74 · 2026-05-22T12:55:56Z

@hansemannn after reviewing your PR, I would say it´s an alternative, but I will check what you PR is doing...

designbymind · 2026-05-22T18:49:14Z

@hansemannn @mbender74 — I just wanted to drop in and say that I've tested PR #14450 on iOS 26.5 by patching a version of TiSDK 13.2.0.GA and updating the NappDrawer Module to v3.1.0. — I'm now successfully able to use a TabGroup again as the center window and a NavigationWindow as both the left/right windows (see this test code) ✨

designbymind · 2026-05-23T01:36:29Z

To iterate on my last comment, I was able to do some further testing and I'm hitting another (related) issue...

Looks like adding/opening a TabGroup, specifically within the NappDrawer module, works great after apply #14450. However, after closing the drawer (with TabGroup center window), and attempting to reopen (or initialize) a new NappDrawer with TabGroup instance, the log output indicates that the drawer/TabGroup exist but the drawer (and TabGroup) are not visible (app is a blank screen). — This may affect apps that use a login/auth process prior access to or displaying the drawer/TabGroup.

I'm going to test further on this and extend my TestApp to support open/close of the drawer/TabGroup. This first test was done in a larger app but I don't believe that's the issue here as this pattern worked prior to very first UIViewControllerHierarchyInconsistency issue with TabGroup back when iOS 26 first landed...

mbender74 · 2026-05-23T06:59:53Z

@designbymind could you provide a full test case for me to reproduce the crashes you encountered?

hansemannn · 2026-05-23T08:03:13Z

The most important part for me here is that the core SDK does not have containment issues anymore. NappDrawer is great, but if it's architecture is not properly compatible with the fixed core, the drawer module should handle that, not the SDK. That said, I am happy to accept @mbender74's PR, as long as it fixes all isssues that this one fixed.

mbender74 · 2026-05-23T08:52:49Z

I will further adapt NappDrawer to work properly....

mbender74 · 2026-05-23T11:06:09Z

@hansemannn after this weekend, I take a closer look at this (your) PR and I can imagine, there are some benefits too... than, we combine them...

hansemannn · 2026-05-23T13:00:43Z

Sounds good!

designbymind · 2026-05-23T20:33:51Z

@designbymind could you provide a full test case for me to reproduce the crashes you encountered?

@mbender74 here's a simple test case (app.js) that you should be able to drop in a run (NappDrawer module inclusion required of course). You'll see an "Open Drawer" Button (it will open a drawer), you'll see a "Close Drawer" Button (it will close the drawer and return you to the first screen), clicking "Open Drawer" Button a second time will initialize the drawer (again) but there will be no windows or drawer functionality and/or no errors/logs...

Perhaps we should bring this over to the NappDrawer repo? — Not trying to dirty this comment thread with semi-unrelated material, just attempting to help solve the issue 😌

designbymind · 2026-05-24T23:24:07Z

For anyone interested in using a modernized/updated version of NappDrawer, check out v3.1.2 by @mbender74 🚪

fix(ios): fix containment issues once and for all

ffc0843

Uh oh!

Conversation

hansemannn commented Feb 23, 2026

Uh oh!

hansemannn commented Feb 23, 2026

Uh oh!

designbymind commented Feb 25, 2026

Uh oh!

hansemannn commented Feb 25, 2026

Uh oh!

designbymind commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

designbymind commented Feb 25, 2026

Uh oh!

hansemannn commented Mar 15, 2026

Uh oh!

designbymind commented Mar 16, 2026

Uh oh!

hansemannn commented Mar 18, 2026

Uh oh!

designbymind commented Mar 18, 2026

Uh oh!

hansemannn commented Mar 18, 2026

Uh oh!

designbymind commented Mar 18, 2026

Uh oh!

hansemannn commented Mar 18, 2026

Uh oh!

designbymind commented Mar 18, 2026

Uh oh!

mbender74 commented May 22, 2026

Uh oh!

hansemannn commented May 22, 2026

Uh oh!

mbender74 commented May 22, 2026

Uh oh!

designbymind commented May 22, 2026

Uh oh!

designbymind commented May 23, 2026

Uh oh!

mbender74 commented May 23, 2026

Uh oh!

hansemannn commented May 23, 2026

Uh oh!

mbender74 commented May 23, 2026

Uh oh!

mbender74 commented May 23, 2026

Uh oh!

hansemannn commented May 23, 2026

Uh oh!

designbymind commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

designbymind commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

designbymind commented Feb 25, 2026 •

edited

Loading

designbymind commented May 23, 2026 •

edited

Loading