fix: type AvAudioSessionChannel.channelLabel as number#277
Merged
tien merged 2 commits intofeat/fabric-viewfrom Mar 21, 2026
Merged
fix: type AvAudioSessionChannel.channelLabel as number#277tien merged 2 commits intofeat/fabric-viewfrom
AvAudioSessionChannel.channelLabel as number#277tien merged 2 commits intofeat/fabric-viewfrom
Conversation
|
Co-authored-by: tien <19813755+tien@users.noreply.github.com> Agent-Logs-Url: https://github.com/tien/react-airplay/sessions/9cd5d0dc-8959-4bd8-83da-ab9ac1f5493d
Copilot
AI
changed the title
[WIP] Apply feedback on React Native architecture support PR
fix: type Mar 21, 2026
AvAudioSessionChannel.channelLabel as number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
channelLabelwas typed asstring, but the native iOS side emits it as a numericAVAudioChannelLabelvia@(channel.channelLabel), causing a type mismatch for TS consumers.Change
AvAudioSessionChannel.channelLabel:string→number💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.