Skip to content

feat(FRNet): apply softmax & fix dataset path#199

Merged
amadeuszsz merged 4 commits intotier4:mainfrom
amadeuszsz:feat/frnet-softmax
Mar 23, 2026
Merged

feat(FRNet): apply softmax & fix dataset path#199
amadeuszsz merged 4 commits intotier4:mainfrom
amadeuszsz:feat/frnet-softmax

Conversation

@amadeuszsz
Copy link
Collaborator

Summary

Apply softmax and deploy FRNet model with probabilities output as we do in PTv3.

Additionally fix the dataset path for test in deployment script.

Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
@amadeuszsz amadeuszsz requested a review from KSeangTan March 19, 2026 11:06
@amadeuszsz amadeuszsz self-assigned this Mar 19, 2026
@amadeuszsz amadeuszsz requested a review from Copilot March 23, 2026 02:29
@amadeuszsz
Copy link
Collaborator Author

@codex review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the FRNet deployment pipeline to output per-class probabilities (via softmax) across Torch/ONNX/TensorRT backends, and adjusts the T4 dataset GT mask path handling to work with paths stored relative to the workspace root.

Changes:

  • Wrap the PyTorch model with an ExportModel that returns softmax(seg_logit) and use it for ONNX export and Torch inference.
  • Rename deployment output from seg_logit to pred_probs across deploy configs and TensorRT runtime wrapper.
  • Fix T4 dataset semantic mask path handling by no longer blindly joining dataset_dir and instead resolving via existence checks.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
projects/FRNet/deploy/trt_model.py Switch TRT expected output tensor name to pred_probs and document probability output.
projects/FRNet/deploy/torch_model.py Add ExportModel wrapper to expose probability output and update Torch inference.
projects/FRNet/deploy/postprocessing.py Update docs to reflect probability-based postprocessing.
projects/FRNet/deploy/onnx_model.py Update docs to reflect probability output from ONNX Runtime.
projects/FRNet/deploy/main.py Export ONNX from torch_model.export_model instead of the raw model.
projects/FRNet/deploy/dataset.py Adjust T4 mask path handling to avoid incorrect dataset_dir joins.
projects/FRNet/configs/deploy/t4dataset/frnet_tensorrt_dynamic.py Rename ONNX/TRT output to pred_probs and update dynamic axes/config entries.
projects/FRNet/configs/deploy/nuscenes/frnet_tensorrt_dynamic.py Rename ONNX/TRT output to pred_probs and update dynamic axes/config entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbe14f5adb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
Copy link
Collaborator

@KSeangTan KSeangTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, please resolve the comments and merge afterwards

Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
@amadeuszsz amadeuszsz merged commit 0a67a94 into tier4:main Mar 23, 2026
2 checks passed
@amadeuszsz amadeuszsz deleted the feat/frnet-softmax branch March 23, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants