Add dependency-free NumericUpDown control for MAUI by tig · Pull Request #60 · tig/winprint

tig · 2026-05-28T18:46:40Z

Summary

Adds a reusable NumericUpDown control to WinPrint.Maui, built entirely on Microsoft.Maui.Controls primitives — no third-party UI toolkit dependency. This is the option-1 approach (combine an Entry with Stepper-style buttons) requested for the WinForms→MAUI port.

The control is a code-defined ContentView placing the up/down buttons below the text box, with these bindable properties:

Property	Type	Purpose
`Value`	`double`	Two-way bindable current value
`Increment`	`double`	Step applied by the up/down buttons
`IsInteger`	`bool`	Whole-numbers-only mode (rounds + formats without decimals)
`Minimum` / `Maximum`	`double`	Bounds, enforced via value coercion

Behavior:

Coercion clamps Value into [Minimum, Maximum] and rounds to whole numbers when IsInteger is set — applied for button clicks, bindings, and typed input alike.
Typed text is parsed on Completed/Unfocused, then snapped back to the canonical value; invalid input reverts.
Changing Minimum, Maximum, or IsInteger re-applies coercion to the current value.
StepUp() / StepDown() are public so callers can drive it programmatically.

MainPage.xaml gains two live examples (an integer "Copies" 1–999 and a decimal "Margin" 0–10 stepping by 0.25).

Tests

Adds tests/WinPrint.Maui.UnitTests, a platform-neutral net10.0 xUnit project that compiles the control's source directly. Because the MAUI app project targets only windows/maccatalyst (which can't build on Linux), compiling the source into a neutral test assembly lets the cross-platform logic build and run on any host, including CI on Linux. 15 tests cover clamping, integer rounding (half-away-from-zero), decimal preservation, step math, bound-respecting steps, and re-coercion when settings change.

Bugs caught while verifying

Building and running the code surfaced real defects that are fixed in this PR:

CS0102 name collision — the increment/decrement methods shared the name Increment with the step property. Renamed to StepUp/StepDown.
Coercion not re-applied — relying on BindableObject.CoerceValue to re-clamp when Minimum/Maximum/IsInteger changed did not actually re-apply coercion (its semantics differ from WPF). Replaced with an explicit ReapplyCoercion that re-runs the coerce delegate and refreshes the text.

Notes / not covered

The windows/maccatalyst app build and the MainPage.xaml wiring still need a real Windows/Mac build to validate end-to-end — the MAUI workload doesn't build those targets on Linux. The control's C# is verified-compiling and unit-tested.
Press-and-hold auto-repeat is not implemented (one step per click); the ▲/▼ glyphs can be swapped for icons if preferred.

https://claude.ai/code/session_01NrcwMcieTftQCjVg9D28Cz

Generated by Claude Code

- Remove git submodules: src/libvt100, src/PowershellAsync, src/LiteHtmlSharp - Delete src/WinPrint.PowerShell (PS cmdlet project) - Delete src/WinPrint.LiteHtml (replaced by TextMateSharp) - Delete proto/ (old UWP/WPF/node/TypeScript prototypes) - Delete tools/ (pygmentize.exe and pygments scripts replaced by TextMateSharp) - Update src/WinPrint.slnx: remove External folder, WinPrint.LiteHtml, WinPrint.PowerShell - Update WinPrint.Core.csproj: remove ProjectReferences to deleted projects - Stub AnsiCte and HtmlCte to compile without deleted native deps (libvt100/LiteHtmlSharp) - Remove LiteHtmlSharp using from WinPrint.WinForms/MainWindow.cs - Remove pygmentize.exe PostBuild copy from WinPrint.WinForms and UnitTests csproj - Fix WinPrint.cli icon reference (was pointing into deleted WinPrint.PowerShell dir) - Skip AnsiCte rendering tests since libvt100 submodule is removed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove dead/obsolete projects and dependencies

Introduce IGraphicsContext and IPrintService in WinPrint.Core, add a System.Drawing graphics adapter, and route SheetViewModel/CTE/HeaderFooter painting through the abstraction. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Add root .editorconfig modeled on gui-cs/clet (file-scoped namespaces, var-when-apparent, space before parens) merged with universal indent rules from gui-cs/cli. - Add Directory.Build.props enabling Nullable, TreatWarningsAsErrors, EnforceCodeStyleInBuild, and latest LangVersion across all projects. - Add empty Directory.Build.targets. - Add .config/dotnet-tools.json pinning JetBrains ReSharper CLI tools. - Replace dotnetcore.yml with ci.yml mirroring gui-cs/cli: build, jb cleanupcode + dotnet format style verification, test. - Replace local Terminal.Gui.Cli submodule with published NuGet package Terminal.Gui.Cli 0.1.0-develop.5. - Remove redundant per-project Nullable and LangVersion settings now provided by Directory.Build.props. - Add Solution Items references for Directory.Build.* and .editorconfig. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Applied dotnet format with IDE0161 (file-scoped namespaces) and IDE0011 (add braces) across all projects. Also normalizes line endings to LF per new .gitattributes and .editorconfig settings. No behavior changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Run JetBrains ReSharper cleanupcode + dotnet format to bring the codebase to the canonical CI style. Pure formatting changes; no behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

New Roslyn analyzer project under tools/WinPrint.Analyzers/: WPA0001 - One type per file WPA0002 - No nested type declarations Generated files (*.Designer.cs, *.Generated.cs, *.g.cs, *.g.i.cs, anything under bin/ or obj/, and files with <auto-generated> headers) are exempt. All rules are warnings, escalated to errors via the existing TreatWarningsAsErrors setting in Directory.Build.props. Directory.Build.props wires the analyzer into every project except the analyzer project itself via ProjectReference with OutputItemType=Analyzer. Violations still need to be fixed in follow-up commits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The nullable cleanup pass initialized Settings.location and Settings.size to 'new ()' to satisfy non-nullable field requirements. This caused MainWindow's 'if (Settings.Size != null) Size = new Size(Width, Height)' guard to take the branch on first run, sizing the window to 0x0 / 0,0. Make the backing fields and properties nullable instead, restoring the pre-existing semantics where null means 'use OS/WinForms default'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Define graphics and print abstractions in WinPrint.Core

Add initial .NET MAUI scaffold with WinPrint.Core integration hooks and solution registration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@tig

After the rebase onto post-PR-#58 develop, the new WinPrint.Maui project breaks CI in three ways. Address them on this branch: * Install the maui workload before restore (NETSDK1147 maui-tizen). * Switch CI restore/build from msbuild to dotnet because the MacCatalyst SDK targets can't load Xamarin.MacDev.Tasks under the .NET Framework MSBuild.exe shipped by setup-msbuild. * Suppress NU1902/NU1903 in WinPrint.Maui.csproj only - they come from transitive MAUI template deps (System.Private.Uri 4.3.0) we don't reference directly and can't upgrade. Other projects still enforce the audit. * Apply jb cleanupcode + dotnet format to the new MAUI files so the 'Verify code style' step is clean. Addresses Codex review on src/WinPrint.slnx and items 1-6 of @tig's review comment on PR #57. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

When dotnet build src/WinPrint.slnx builds the two WinPrint.Maui target frameworks (net10.0-windows10.0.19041.0 and net10.0-maccatalyst) in parallel, both reference WinPrint.Analyzers via Directory.Build.props. This races on writing the analyzer DLL and fails with CS2012 ('Cannot open ... for writing'). Build the analyzer once up-front so the solution build only loads it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Create WinPrint.Maui project shell

Reusable ContentView combining an Entry with up/down buttons placed below the text box. Supports configurable Increment, integer-vs-decimal mode via IsInteger, and Minimum/Maximum bounds with value coercion (clamping and integer rounding). Built only on Microsoft.Maui.Controls primitives. Adds usage examples to MainPage.

The increment/decrement methods shared the name 'Increment' with the step property (CS0102). Renamed them to StepUp/StepDown. Verified the control compiles cleanly against Microsoft.Maui.Controls 10.0.20 with warnings as errors.

Adds WinPrint.Maui.UnitTests, a platform-neutral (net10.0) xUnit project that compiles the control's source directly so the cross-platform logic can be tested and run on any host (including Linux CI). 15 tests cover clamping, integer rounding, and step math. Writing the tests surfaced a real bug: relying on BindableObject.CoerceValue to re-clamp the value when bounds or IsInteger changed did not actually re-apply coercion. Replaced with an explicit ReapplyCoercion that re-runs the coerce delegate and refreshes the text.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c0615e35f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-28T18:48:58Z

+        LogService.TraceMessage ("HtmlCte is a stub - LiteHtmlSharp dependency removed.");
+        return await Task.FromResult (0);


Restore HTML rendering instead of returning zero pages

When a user opens or prints an .htm/.html file, the default settings still map those extensions to text/html, and this class still advertises text/html, but RenderAsync now just logs and returns 0 pages while PaintPage is empty. That turns HTML printing into a silent blank/no-page output path, whereas the parent implementation rendered the document through LiteHtml.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-28T18:48:58Z

+          git diff --exit-code
+
+      - name: Test
+        run: dotnet test tests/WinPrint.Core.UnitTests/WinPrint.Core.UnitTests.csproj --configuration Debug -p:Platform=x64 --no-build --verbosity normal


Run the new MAUI tests in CI

This workflow's only test step still runs WinPrint.Core.UnitTests, and the new WinPrint.Maui.UnitTests project is not referenced from src/WinPrint.slnx either, so the NumericUpDown tests added by this commit are not restored, built, or executed on PRs. Regressions in the new control can therefore merge even though the commit relies on those tests to validate clamping, rounding, and step behavior.

Useful? React with 👍 / 👎.

tig · 2026-05-29T02:01:22Z

Context for reviewers / future sessions

Notes that aren't obvious from the diff:

This is the dependency-free option (combine Entry + buttons), chosen over Syncfusion/Telerik/Xceed to avoid a new UI dependency. Up/down buttons sit below the text box; bindable Value/Increment/IsInteger/Minimum/Maximum with value coercion.
The increment/decrement methods are named StepUp/StepDown because Increment collided with the step property (a CS0102 the compiler caught) — don't rename them back.
Build/verification caveat: the MAUI app can't be built on the Linux container this was developed in (the maui workload isn't supported there). The control's C# was type-checked against Microsoft.Maui.Controls and is covered by the coercion unit tests, but the XAML wiring and on-device layout still need a real Windows/Mac build.
CI gap: .github/workflows/ci.yml only runs WinPrint.Core.UnitTests, so this PR's MAUI NumericUpDown tests won't execute in CI. If you want them gated, the test step (or a separate job) needs to run the MAUI test project too.
Not implemented: press-and-hold auto-repeat (one step per click). Easy follow-up if wanted.

(Separately, PR #65 adds a web SessionStart hook + CLAUDE.md to make future sessions test-ready and capture architecture/decisions.)

Generated by Claude Code

tig and others added 30 commits February 6, 2022 18:52

Updated to vs2022, net6.0, etc...

c0b3b64

more updates

0c49705

more

0ba93cb

more net6 tweaks

b4d68d6

removed old files

32f4746

added comments

610c3c0

added comments

22fe185

Moved default Cte to settings:

307fc1a

simplified ansicte line number logic

e517066

csproj

005a5a2

Improved rendering of AnsiCte - faster!

4f0c055

Fixed #36 - Home/End keys in print preview

2fd88aa

Fixed focus issue after file load.

6090ae1

pygments install checks

05eb2ae

fighting with dotnet

eb1e052

Fixed #32 (-gui), Fixed #35 (in console)

1944a91

merge

4716396

new machine setup

22e4053

Trhing to build installer

a428351

Updated test packages

2e3ddd3

Updated to PS 7.2.5

2db54db

updated submodules

33860f2

Fixed pwsh debugging

c19f72b

updated debug target

928d7f0

changed case to Out-WinPrint

8fb7fe2

Kindel Systems -> Kindel

b8fbdac

2.0 -> 2

abf3f66

Created External solution folder

2a20b28

removed msbump

eb81dd4

Fixed litehtml and litehtmlsharp

7a791f4

tig and others added 28 commits May 26, 2026 14:48

Merge pull request #56 from tig/tig/cleanup-dead-projects

06fa2a0

Remove dead/obsolete projects and dependencies

Add graphics and print abstractions

6bce763

Introduce IGraphicsContext and IPrintService in WinPrint.Core, add a System.Drawing graphics adapter, and route SheetViewModel/CTE/HeaderFooter painting through the abstraction. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Preserve fractional clip bounds in graphics adapter

23375fb

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix nullable and analyzer warnings in core

65c2eed

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix WinForms build warnings

0a65268

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix unit test build warnings

c501c65

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove #nullable disable from WinForms, fix nullable warnings properly

ba48d85

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove #nullable disable from unit tests, fix nullable warnings properly

d439388

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Apply jb cleanupcode formatting

0ad4593

Run JetBrains ReSharper cleanupcode + dotnet format to bring the codebase to the canonical CI style. Pure formatting changes; no behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Split multi-type core files

30958ec

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Promote SystemDrawing adapter types

064a7c2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Promote sheet settings event type

2631344

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Flatten native association enums

cbcd217

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Apply jb cleanupcode formatting

872de97

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Apply analyzer cleanupcode formatting

24bc46b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge pull request #58 from tig/tig/graphics-print-abstractions

249f41e

Define graphics and print abstractions in WinPrint.Core

Create WinPrint.Maui project shell

cf31b92

Add initial .NET MAUI scaffold with WinPrint.Core integration hooks and solution registration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge pull request #57 from tig/tig/maui-project-shell

26863f9

Create WinPrint.Maui project shell

Fix Increment name collision in NumericUpDown

996e361

The increment/decrement methods shared the name 'Increment' with the step property (CS0102). Renamed them to StepUp/StepDown. Verified the control compiles cleanly against Microsoft.Maui.Controls 10.0.20 with warnings as errors.

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add dependency-free NumericUpDown control for MAUI#60

Add dependency-free NumericUpDown control for MAUI#60
tig wants to merge 86 commits into
mainfrom
claude/hopeful-rubin-M9bCR

tig commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Uh oh!

tig commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		LogService.TraceMessage ("HtmlCte is a stub - LiteHtmlSharp dependency removed.");
		return await Task.FromResult (0);

Uh oh!

Conversation

tig commented May 28, 2026

Summary

Tests

Bugs caught while verifying

Notes / not covered

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

tig commented May 29, 2026

Context for reviewers / future sessions

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants