GML-2131: Respect configured TigerGraph ports during UI login#44
Open
OmarAyo1 wants to merge 1 commit into
Open
GML-2131: Respect configured TigerGraph ports during UI login#44OmarAyo1 wants to merge 1 commit into
OmarAyo1 wants to merge 1 commit into
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
01d1bc0 to
2319b01
Compare
2319b01 to
59ab0aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
PR Type
Bug Fix
Description
Respect configured TigerGraph
gsPortandrestppPortduring UI loginFix
/ui/ui-loginincorrectly falling back to pyTigerGraph default RESTPP port9000Apply the same connection port configuration to both username/password and API-token login paths
Prevent valid TigerGraph credentials from being rejected when TigerGraph is exposed on a non-default port such as
14240Diagram Walkthrough
File Walkthrough
Relevant files
Bug Fix 1 file
graphrag/app/routers/ui.pyPass configured TigerGraph gsPort/restppPort into UI login TigerGraphConnection callsValidation
Reproduced the issue with TigerGraph exposed on port
14240Confirmed
TigerGraphConnection(..., gsPort=14240, restppPort=14240)succeeds with the same credentialsConfirmed the existing
/ui/ui-loginpath fails because it falls back to port9000Confirmed
/ui/ui-loginreturns200 OKafter passing configuredgsPortandrestppPortPR Type
Bug fix
Description
Pass configured ports to UI login
Fix non-default TigerGraph port authentication
Diagram Walkthrough
File Walkthrough
ui.py
Configure TigerGraph ports for UI authenticationgraphrag/app/routers/ui.py
gsPortfromdb_configto UI login connectionsrestppPortfromdb_configto UI login connections