-
Notifications
You must be signed in to change notification settings - Fork 1
fix: storage package dependency versions #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Greptile OverviewGreptile SummaryChanges
For a monorepo setup with workspace packages, dependencies should typically use Confidence Score: 1/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
| @@ -47,7 +47,7 @@ | |||
| }, | |||
| "license": "MIT", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing from * to ^2.0.0 breaks workspace resolution - packages/keyv-tigris will now use the published npm package (2.12.0) instead of the local workspace version (0.0.1), which breaks local development workflow
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/keyv-tigris/package.json
Line: 48:48
Comment:
changing from `*` to `^2.0.0` breaks workspace resolution - `packages/keyv-tigris` will now use the published npm package (2.12.0) instead of the local workspace version (0.0.1), which breaks local development workflow
How can I resolve this? If you propose a fix, please make it concise.| @@ -57,7 +57,7 @@ | |||
| "react-dom": ">=18.0.0" | |||
| }, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing from * to ^2.0.0 breaks workspace resolution - packages/react will now use the published npm package (2.12.0) instead of the local workspace version (0.0.1), which breaks local development workflow
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react/package.json
Line: 58:58
Comment:
changing from `*` to `^2.0.0` breaks workspace resolution - `packages/react` will now use the published npm package (2.12.0) instead of the local workspace version (0.0.1), which breaks local development workflow
How can I resolve this? If you propose a fix, please make it concise.|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Note
Locks
@tigrisdata/storageto^2.0.0inpackages/keyv-tigrisandpackages/reactto avoid floating versions.package-lock.jsonto resolve@tigrisdata/storageto2.12.0with new AWS/Smithy transitive depsWritten by Cursor Bugbot for commit aeebd58. This will update automatically on new commits. Configure here.