feat: register team-discover hooks + add Skill Check step to preset commands#103
Merged
Conversation
…ommands The team-ai-directives extension declared no hooks in its extension.yml, so register_hooks() wrote nothing for before_specify/before_plan. The team.discover.md command documented these hooks but the manifest never declared them — leaving personas, rules, examples, and team skills undiscovered during /spec.specify and /spec.plan. Changes: - team-ai-directives/extension.yml: add hooks block with mandatory before_specify + before_plan hooks (optional: false) pointing at adlc.team-ai-directives.discover. Bump to v4.2.0. - 11 preset command files (agentic-sdlc + agentic-quick): add generic Skill Check step before the extension hook checks. Bridges the ambient AGENTS.md Strict Compliance directive into the procedural flow so it is not overridden by the STOP-execute-hooks tunnel. Fully generic — no specific skill names referenced. - update-agent-context.sh/.ps1/.py: strengthen Strict Compliance bullet with "This is not optional and applies to every interaction." - test_team_ai_directives_declares_hooks: verify manifest declares both hooks with correct command and optional: false. - Version bump to 0.12.15+adlc3. Existing workspaces: run `specify extension update team-ai-directives` to populate the new hooks in .specify/extensions.yml. Assisted-by: opencode (model: glm-5.2, supervised)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
team-ai-directivesextension declared no hooks in itsextension.yml, soregister_hooks()wrote nothing forbefore_specify/before_plan. Theteam.discover.mdcommand documented these hooks but the manifest never declared them — leaving personas, rules, examples, and team skills undiscovered during/spec.specifyand/spec.plan.This was found by reviewing a session trace of
/spec.constitutionand/spec.specifywhere team skills were never triggered despite the AGENTS.md injection being present.Changes
Part 1: Register team-discover hooks (
extensions/team-ai-directives/extension.yml)hooks:block with mandatorybefore_specify+before_planhooks (optional: false) pointing atadlc.team-ai-directives.discover.register_hooks(manifest)now writes these to.specify/extensions.yml, so the spec workflow's existing pre-execution hook checks auto-invoke/team.discover.4.2.0.Part 2: Add generic Skill Check step to 11 preset command files
agentic-sdlc(9adlc.spec.*+adlc.spec.specify) andagentic-quick(adlc.quick.implement) now include a generic "Skill Check" step before the extension hook checks.Part 3: Strengthen AGENTS.md injection text
update-agent-context.sh/.ps1/.py: strengthened "Strict Compliance" bullet with "This is not optional and applies to every interaction."Part 4: Tests, CHANGELOGs, version bump
test_team_ai_directives_declares_hooks: verifies manifest declares both hooks with correct command andoptional: false.0.12.15+adlc3entry.extensions/team-ai-directives/CHANGELOG.md:4.2.0entry.pyproject.toml: version bump to0.12.15+adlc3.Test plan
test_team_ai_directives_declares_hookspassestest_bundled_extension_hooks.py+test_extensions.py+test_extension_registration.py+test_agent_config_consistency.py)specify extension update team-ai-directivesin a workspace with team-ai-directives installed, verifybefore_specifyandbefore_planhooks appear in.specify/extensions.ymlMigration
Existing workspaces: run
specify extension update team-ai-directivesto populate the newbefore_specify/before_planhooks in.specify/extensions.yml.Assisted-by: opencode (model: glm-5.2, supervised)