Skip to content

fix(ci): windows-x86 SSH probe — Bun.spawnSync timeout returns null exitCode #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mobileskyfi merged 3 commits into from
Jul 10, 2026
Merged

fix(ci): windows-x86 SSH probe — Bun.spawnSync timeout returns null exitCode #93

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
476b49c
test(provisioning): surface stderr/exit code from the SSH probe on fa…
mobileskyfi Jul 10, 2026
36d72c1
test(provisioning): switch SSH probe from spawnSync to spawn (matches…
mobileskyfi Jul 10, 2026
05be9ce
review: address Copilot PR feedback on the SSH probe rewrite
mobileskyfi Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions test/integration/provisioning.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,8 +499,16 @@ describe.skipIf(SKIP)("SSH key provisioning", () => {

// Independent grounding of that flag: a real host-OpenSSH batch login
// (BatchMode=yes, PasswordAuthentication=no) with the managed key must work.
//
// Uses the same async Bun.spawn + manual-kill-timer shape as
// verifyBatchLogin() (src/lib/provision.ts) rather than Bun.spawnSync's
// `timeout` option. On windows-x86, Bun.spawnSync here reproduced 3/3 as an
// instant, undiagnosable `exitCode: null` with empty stdout+stderr (~400ms
// after account creation — nowhere near any real timeout), while the async
// form used by verifyBatchLogin() has never failed that way in the same CI
// runs. This is that hypothesis under direct test.
const emptyConfig = await ensureEmptySshConfig(sshDir);
const login = Bun.spawnSync(
const loginProc = Bun.spawn(
[
"ssh",
"-F", emptyConfig,
Expand All @@ -514,10 +522,30 @@ describe.skipIf(SKIP)("SSH key provisioning", () => {
`quickchr@127.0.0.1`, "-p", String(instance.ports.ssh),
':put "managed-key-login-ok"',
],
{ stdout: "pipe", stderr: "pipe", timeout: 20_000 },
{ stdout: "pipe", stderr: "pipe", stdin: "ignore" },
);
const loginOut = new TextDecoder().decode(login.stdout);
expect(loginOut).toContain("managed-key-login-ok");
const loginTimer = setTimeout(() => {
try { loginProc.kill(); } catch { /* already gone */ }
}, 20_000);
// Initialized up front (not `let x: string` assigned only on the happy path) and
// matched against combined stdout+stderr like verifyBatchLogin() does, not stdout
// alone — makes the failure mode deterministic and avoids missing a success message
// ssh happened to emit on stderr (review: github.com/tikoci/quickchr/pull/93).
let combined = "";
try {
const [out, err] = await Promise.all([
new Response(loginProc.stdout).text(),
new Response(loginProc.stderr).text(),
]);
const exitCode = await loginProc.exited;
combined = (out + err).trim();
if (!combined.includes("managed-key-login-ok")) {
console.error(`[ssh probe] exit ${exitCode}: ${combined || "<no output>"}`);
}
} finally {
clearTimeout(loginTimer);
}
expect(combined).toContain("managed-key-login-ok");
} finally {
if (instance) {
try { await instance.stop(); } catch { /* ignore */ }
Expand Down