add request head to getGCState

[CalvinNeo]

Summary by CodeRabbit

• Bug Fixes
  • Enhanced request header initialization to ensure proper identification of request sources and cluster context.

[coderabbitai]

📝 Walkthrough

Walkthrough

The Client::getGCState(KeyspaceID) method was refactored to construct the request header via a local pointer, enabling explicit assignment of cluster_id and caller_id fields to "tiflash" before attaching it to the request, rather than directly using the unmodified requestHeader() result.

Changes

Cohort / File(s)	Summary
Request Header Initialization src/pd/Client.cc	Modified Client::getGCState(KeyspaceID) to use a local header pointer for explicit configuration of cluster_id and caller_id fields prior to request attachment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A header now takes shape with care,
With cluster_id and caller declared fair,
In TiFlash's name, the request takes flight,
One tiny method, perfected right! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'add request head to getGCState' accurately describes the main change: adding a request header to the getGCState method with explicit cluster_id and caller_id fields.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/pd/Client.cc (1)

371-374: Attach the allocated header before mutating request-specific fields.

Line 371 holds an owning raw pointer until Line 374. Attach it immediately, then mutate the request-owned header; this also removes the redundant cluster_id assignment because requestHeader() already sets it.

♻️ Proposed refactor

-    auto * header = requestHeader();
-    header->set_cluster_id(cluster_id);
-    header->set_caller_id("tiflash");
-    request.set_allocated_header(header);
+    request.set_allocated_header(requestHeader());
+    request.mutable_header()->set_caller_id("tiflash");

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pd/Client.cc` around lines 371 - 374, Obtain the header via
requestHeader(), immediately call request.set_allocated_header(header) to
transfer ownership, then mutate request-owned fields (e.g., call
header->set_caller_id("tiflash")); remove the redundant
header->set_cluster_id(cluster_id) because requestHeader() already initializes
cluster_id. This ensures no lingering owning raw pointer and that mutations
happen on the request-owned header.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/pd/Client.cc`:
- Around line 371-374: Obtain the header via requestHeader(), immediately call
request.set_allocated_header(header) to transfer ownership, then mutate
request-owned fields (e.g., call header->set_caller_id("tiflash")); remove the
redundant header->set_cluster_id(cluster_id) because requestHeader() already
initializes cluster_id. This ensures no lingering owning raw pointer and that
mutations happen on the request-owned header.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7f6a6114-803a-43c8-9014-715142d3f993

📥 Commits

Reviewing files that changed from the base of the PR and between 88ca06e and 8291521.

📒 Files selected for processing (1)

• src/pd/Client.cc

[ti-chi-bot]

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2026-04-21 13:54:41.192069697 +0000 UTC m=+2087686.397429754: ☑️ agreed by gengliqi.
• 2026-04-21 15:07:37.03305849 +0000 UTC m=+2092062.238418557: ☑️ agreed by 3pointer.

[ti-chi-bot]

@wfxr: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, cfzjywxk, gengliqi, JaySon-Huang, wfxr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cfzjywxk,gengliqi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CalvinNeo]

/merge

[CalvinNeo]

/retest

[gengliqi]

/merge