transaction: Add "scan_locks" & "resolve_locks" interface for transaction client#524
Merged
ti-chi-bot[bot] merged 11 commits intotikv:masterfrom Jan 21, 2026
Merged
Conversation
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
ea57fdd to
9b9e80a
Compare
Signed-off-by: Ping Yu <yuping@pingcap.com>
coocood
approved these changes
Jan 21, 2026
iosmanthus
approved these changes
Jan 21, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coocood, iosmanthus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
pingyu
added a commit
to pingyu/client-rust
that referenced
this pull request
Jan 25, 2026
…tion client (tikv#524) Signed-off-by: Ping Yu <yuping@pingcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
src/transaction/client.rs:300,src/transaction/client.rs:322).Vec<LockInfo>so locks returned/truncated by scan_locks can be re-encoded before resolving (src/request/keyspace.rs:185).src/request/plan.rs:91) and harden ResolveLock retries with backoff + cache invalidation (src/transaction/lock.rs:145).src/transaction/lock.rs:626,src/transaction/lock.rs:674) and an integration failpoint test for the new API (tests/failpoint_tests.rs:287).Compare with Go implementation by LLM:
src/transaction/lock.rs:51) follows the same non-async, non-pessimistic flow: CheckTxnStatus per txn, then ResolveLock per txn+region with per-txn commit-version + cleaned-region caching(mirrors Go’s cleanTxns).
src/transaction/lock.rs:145) now matches Go’s resolveLock loop more closely: backoff-based retries, region-error handling via handle_region_error, plus region/store cache invalidation on leader/grpc issues.