Conversation
|
Welcome @ArchangelX360! It looks like this is your first PR to tikv/jemallocator 🎉 |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe jemalloc-sys build script now reads Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
jemalloc-sys/build.rs (1)
165-201:⚠️ Potential issue | 🟠 MajorTrack
LDFLAGSchanges with Cargo rerun metadata.
ReadingLDFLAGSviaenv::varmeans Cargo won't rerun the build when it changes, and target-prefixed versions (e.g.,X86_64_UNKNOWN_LINUX_GNU_LDFLAGS) are ignored. Useread_and_watch_env("LDFLAGS")with a fallback tocflagsto correctly trigger rebuilds and honor target-specific overrides.🔧 Suggested fix
- let ldflags = env::var("LDFLAGS").unwrap_or_else(|_| cflags.clone()); + let ldflags = read_and_watch_env("LDFLAGS").unwrap_or_else(|_| cflags.clone());
ddc531d to
cfa3c20
Compare
74d00d2 to
be64fc8
Compare
5b58705 to
78aa7c4
Compare
f4939c1 to
6333d43
Compare
Ensures that when a toolchain is configured with `-fuse-ld` in its `LDFLAGS`, then `jemalloc-sys` selects the right linker. Behavior was observed when using Bazel with an LLVM toolchain. Signed-off-by: Titouan Bion <titouan.bion@gmail.com>
`macos-13` has been deprecated and the CI is failing due to that, actions/runner-images#13046 Signed-off-by: Titouan Bion <titouan.bion@gmail.com>
6333d43 to
96e8c80
Compare
The following PR add propagation of
LDFLAGSenv var in thebuild.rs.We had a failure compiling
jemalloc-syscrate in Bazel using an LLVM toolchain as our-fuse-ldflag was not respected by thebuild.rsfor example.The
build.rswas trying to fall back to the OS'sldlinker incorrectly, which not only did not work, but also broke hermeticity.Closes #156
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.