server/resource_group: add allocation observability#10605
server/resource_group: add allocation observability#10605okJiang wants to merge 1 commit intotikv:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10605 +/- ##
==========================================
+ Coverage 78.96% 78.98% +0.01%
==========================================
Files 532 532
Lines 71883 72083 +200
==========================================
+ Hits 56766 56937 +171
- Misses 11093 11116 +23
- Partials 4024 4030 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
What problem does this PR solve?
Issue Number: ref #10488
Resource control observability on the server side does not clearly show why tokens are granted slowly, whether
service_limitis involved, or whether server-side metrics stay correct across cleanup and edge cases.What is changed and how does it work?
This PR adds server-side allocation metrics and fixes several correctness gaps so the controller and server can be diagnosed together.
It includes:
service_limitversusgroup_fill_rate_or_burstCheck List
Tests
Manual test:
tiup playgroundsetup with 3 PD, 2 TiDB, and 3 TiKV.service_limitscenario with two resource groups and confirmed Grafana showsservice_limitin throttling causes.group_fill_rate_or_burstwithout falseservice_limitsignals.Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note