Flush all spdlog loggers before processing crash exit#857
Merged
Force67 merged 1 commit intotiltedphoques:devfrom Feb 18, 2026
Merged
Flush all spdlog loggers before processing crash exit#857Force67 merged 1 commit intotiltedphoques:devfrom
Force67 merged 1 commit intotiltedphoques:devfrom
Conversation
…uing to the crash exit will flush all logs synchronously before returning.
rfortier
added a commit
to rfortier/TiltedEvolution-rwf
that referenced
this pull request
Feb 28, 2026
Fix to PR tiltedphoques#857. What the docs did not say is that you must exit pretty much immediately after invoking spdlog::shutdown(), or it can provoke its own crashes. Fixed placement.
Merged
miredirex
pushed a commit
that referenced
this pull request
Feb 28, 2026
Fix to PR #857. What the docs did not say is that you must exit pretty much immediately after invoking spdlog::shutdown(), or it can provoke its own crashes. Fixed placement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to spdlog:: docs, invoking spdlog::shutdown() before continuing to the crash exit will flush all logs synchronously before returning.