Skip to content

feat(classic-brick): raise height limit to 24 plates#2

Merged
timcogan merged 1 commit intomasterfrom
feat/brick-height-24
Apr 14, 2026
Merged

feat(classic-brick): raise height limit to 24 plates#2
timcogan merged 1 commit intomasterfrom
feat/brick-height-24

Conversation

@timcogan
Copy link
Copy Markdown
Owner

@timcogan timcogan commented Apr 14, 2026

Summary by CodeRabbit

  • Documentation

    • Updated maximum height limit for classic brick designs from 9 to 24 plate units in documentation and shareable URL parameters.
  • Tests

    • Updated test configurations to reflect the new height constraint range.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4d33277e-9fbc-4346-a7e2-ad2a1a4aeb00

📥 Commits

Reviewing files that changed from the base of the PR and between 8d73c35 and 22af16a.

📒 Files selected for processing (5)
  • README.md
  • llms-full.txt
  • llms.txt
  • scad/classic_brick.scad
  • tests/share-query.test.mjs

📝 Walkthrough

Walkthrough

The maximum height parameter for the classic_brick template is increased from 9 to 24 plates across all relevant files: documentation, configuration/API definitions, source code metadata, and test assertions.

Changes

Cohort / File(s) Summary
Documentation
README.md
Updated classic_brick height parameter range documentation from 1-9 to 1-24.
Configuration & API Contract
llms-full.txt, llms.txt
Updated classic_brick template height range constraint from 1..9 to 1..24 in both manifest files.
Source Code Metadata
scad/classic_brick.scad
Updated exported parameter metadata (`@param Z
Test Suite
tests/share-query.test.mjs
Updated CLASSIC_TEMPLATE test configuration and assertions to reflect new height maximum of 24, including clamping test input adjustment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Taller bricks, higher dreams so grand,
From nine to twenty-four they stand!
Our fluffy paws did coordinate,
Each file increased, how truly great! 🧱✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the classic-brick template's height parameter limit from 9 to 24 plates across all affected files and tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/brick-height-24

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@timcogan
Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@timcogan timcogan merged commit 6e46adf into master Apr 14, 2026
5 checks passed
@timcogan timcogan deleted the feat/brick-height-24 branch April 14, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant