Skip to content

Improve DICOM SR compatibility #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timcogan merged 6 commits into from
Apr 16, 2026
Merged

Improve DICOM SR compatibility #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
350f055
Improve DICOM SR compatibility
timcogan Apr 10, 2026
efc78e0
Fix SR overlay label clamping, units parsing, and overlay docs
timcogan Apr 10, 2026
7781915
Fix inline SR laterality/view context and measurement label padding
timcogan Apr 10, 2026
97eaef0
Fix SR overlay label matching by image/frame identity
timcogan Apr 10, 2026
55e3580
Keep image context and label source aligned in CAD overlays
timcogan Apr 14, 2026
96034b0
Hydrate context on referenced-content targets
timcogan Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESIGN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Its primary purpose is consistency during development, not full architecture cov
6. Mixed image+SR selections MUST stage SR documents as separate history entries, not image viewports.
7. Supplemental overlay visibility MUST default to off and MUST be user-toggled (`G`).
8. GSPS overlays MUST attach by SOP Instance UID match only.
9. Mammography CAD SR overlays MUST attach by direct referenced-image SOP Instance UID match only, and only `Presentation Required` findings participate in render/navigation.
9. Mammography CAD SR overlays MUST attach by direct referenced-image SOP Instance UID match only. Only `Presentation Required` vector findings participate in render/navigation. Visible SR geometry may carry a short text label derived from the same finding metadata (for example finding meaning, laterality/view, and certainty). Non-geometric descriptive SR content remains available through the document view only.
10. Parametric Map overlays MUST attach only when they carry explicit source-image SOP Instance UID references; no geometry-only or study/series heuristics are allowed.
11. Parametric Map overlays MUST render beneath GSPS and Mammography CAD SR vector overlays.
12. `open_group` MUST be validated/clamped before use.
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Perspecta DICOM Viewer is an open-source Rust desktop DICOM viewer (`egui`/`efra
- Real-time window/level controls for grayscale workflows.
- Multi-frame cine playback (`C` key or UI control).
- GSPS (Grayscale Softcopy Presentation State) overlay support with manual toggle (`G` key, off by default).
- Mammography CAD SR overlay support on matching images, with the same manual overlay workflow as GSPS.
- Mammography CAD SR overlay support on matching images when the SR provides vector marks, with short finding text rendered alongside visible geometry.
- DICOM Parametric Map support for local files, including heatmap overlay on matching source images and standalone opening when no explicit source match is present.
- Structured Report (SR) DICOM support with a dedicated text/document view.
- Live distance measurement with DICOM pixel spacing support when available (`mm`, fallback to `px`).
Expand Down Expand Up @@ -150,7 +150,7 @@ This writes a desktop entry under `~/.local/share/applications`.
## Keyboard Shortcuts

- `C`: toggle cine mode
- `G`: toggle image overlay (GSPS, Mammography CAD SR, or a matching Parametric Map, when available)
- `G`: toggle image overlay (GSPS, Mammography CAD SR marks, or a matching Parametric Map, when available)
- `N`: jump to the next image/frame with an overlay
- `V`: open or close the full metadata field popup for the active object
- `Esc`: exit live measurement mode; if no measurement is active, close the full metadata popup
Expand Down
Loading