fix(gen-skill-docs): preserve embedded periods in catalog leads#3
Open
time-attack wants to merge 1 commit into
Open
fix(gen-skill-docs): preserve embedded periods in catalog leads#3time-attack wants to merge 1 commit into
time-attack wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Skill catalogs keep the full first sentence when it contains a filename, URL, or version, while preserving the following routing guidance.
How it works
The generator treats punctuation inside a token as embedded, then ends the lead at the first punctuation followed by whitespace or end-of-text. Templates are regenerated so committed catalogs match the corrected split.
What was broken
Skill descriptions containing filenames, URLs, or version numbers could be split at the wrong place, hiding the guidance agents use to choose a skill.
How it was fixed
The catalog now recognizes embedded periods without mistaking them for sentence endings. The production matcher was corrected, the known-limitation test was replaced with exact filename/version behavior, URL coverage was added, the diagram template boundary was clarified, and generated artifacts were refreshed.
Live evidence
The isolated baseline/candidate gate used an immutable
origin/mainsnapshot and separate HOME roots.Candidate commands were byte-identical to their stored baseline commands. The final evidence gate passed after the commit and report fingerprint was refreshed.
Secondary checks
bun test test/catalog-trim.test.ts: 21 passed, 0 failedbun run gen:skill-docs --host codex: passedbun run build: passedgit diff --check: passedNo version or release files were changed.
Closes garrytan#2171.