Authentication is not a question (v1.64.6.0)#35
Merged
Conversation
Silent deterministic auth resolution: existing .p8 -> xcodebuild key flags; otherwise announce-and-install fastlane and mint the session. Auth-path menus, API-key options for keyless users, and browser drives for credential creation are contract violations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live nimbus test caught the adapter asking the user to pick between three auth paths, with an Aside-driven API key as the recommended option. Product owner's verdict: the baseline user has exactly one path, so there is nothing to ask.
The adapter now resolves auth silently and deterministically:
.p8already on the machine → use it via xcodebuild key flags, no question.brew install fastlane, covered by the /ship authorization), thenfastlane spaceauth. The user's entire contribution is their password and one 2FA code.Auth-path menus, API-key options shown to keyless users, and browser drives for credential creation are now explicit contract violations. Storefront CLI selection follows the resolved credential (session →
deliver, key →asc) with no second question.Test evidence:
test:gstack2gate green (parity 4,359),release-hardening11/11.🤖 Generated with Claude Code
Summary by cubic
Make Apple release authentication automatic and deterministic. If a
.p8key is present we usexcodebuildkey flags; otherwise we installfastlaneand mintFASTLANE_SESSION—no prompts or menus..p8→xcodebuild -authenticationKey*; else installfastlaneand runfastlane spaceauth. Removed auth-path menus and browser-driven credential creation.deliver; key →asc. Docs updated and version bumped to1.64.6.0.Written for commit c3d6597. Summary will update on new commits.