Modernize TimescaleDB to 2.27.1 (pg17) + rowcount tripwire#10
Draft
mattstratton wants to merge 1 commit into
Draft
Modernize TimescaleDB to 2.27.1 (pg17) + rowcount tripwire#10mattstratton wants to merge 1 commit into
mattstratton wants to merge 1 commit into
Conversation
- Bump TimescaleDB extension 2.18.1 -> 2.27.1 and pg client 16 -> 17. - Switch to the modern columnstore ALTER TABLE syntax (timescaledb.enable_columnstore / segmentby / orderby), keeping the same hand-tuned segmentby/orderby values. - compress.sh: use the modern CALL convert_to_columnstore() procedure, fanned across workers via xargs -P. - run.sh (timescaledb + tiger-cloud): add a rowcount tripwire that warns loudly when a query returns zero rows, so a silent misconfiguration returning empty result sets can't masquerade as a speedup (the timing loop only greps "Time:" and is otherwise blind to this). 0019 is allowlisted because it legitimately returns zero rows on this dataset. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the TimescaleDB modernization and a result-safety check from our internal benchmark work. Draft pending a review of the public-facing wording.
Changes
timescaledb/benchmark.sh— TimescaleDB extension2.18.1 → 2.27.1, pg client16 → 17, and the modern columnstoreALTER TABLEsyntax (timescaledb.enable_columnstore/segmentby/orderby) with the same hand-tunedsegmentby=''/orderby='order_id, event_created'values.timescaledb/compress.sh— use the modernCALL convert_to_columnstore()procedure (replaces the deprecatedSELECT compress_chunk()), fanned across workers viaxargs -P.timescaledb/run.sh+tiger-cloud/run.sh— add a rowcount tripwire: after the timed runs, count each query's rows once and warn loudly (plus an end-of-run summary) if any query returns zero rows. A silent misconfiguration that returns empty result sets otherwise looks like a speedup, because the timing loop only grepsTime:.0019is allowlisted since it legitimately returns zero rows on this dataset (noShippedevents → its anti-join is always true; identical topostgres/queries/0019).Scope
Deliberately limited to the TimescaleDB modernization + the tripwire. Other divergences between this repo and our internal copy (e.g. ClickHouse partitioning, doris) are real but separate, and will come in a follow-up PR.
🤖 Generated with Claude Code