Open
Conversation
timgent
commented
Jul 6, 2021
| dualDsChecks = dualDsMetricChecks, | ||
| metricsPersister = esMetricsPersister, | ||
| qcResultsRepository = qcResultsRepository | ||
| qcResultsRepository = apiQcResultsRepository |
Owner
Author
There was a problem hiding this comment.
Maybe make the example so it's easy to switch between the 2?
timgent
commented
Jul 6, 2021
src/main/scala/com/github/timgent/dataflare/repository/DfApiQcResultsRepository.scala
Outdated
Show resolved
Hide resolved
timgent
commented
Jul 6, 2021
src/main/scala/com/github/timgent/dataflare/repository/DfApiQcResultsRepository.scala
Outdated
Show resolved
Hide resolved
timgent
commented
Jul 6, 2021
src/main/scala/com/github/timgent/dataflare/repository/DfApiQcResultsRepository.scala
Outdated
Show resolved
Hide resolved
timgent
commented
Jul 6, 2021
src/main/scala/com/github/timgent/dataflare/repository/DfApiQcResultsRepository.scala
Outdated
Show resolved
Hide resolved
timgent
commented
Jul 6, 2021
src/main/scala/com/github/timgent/dataflare/repository/DfApiQcResultsRepository.scala
Outdated
Show resolved
Hide resolved
timgent
commented
Jul 6, 2021
| with ScalaCheckDrivenPropertyChecks { | ||
|
|
||
| "DfApiResultsRepository.save" should { | ||
| def generateRawCheckResult(qcType: QcType, suffix: String, status: CheckStatus) = |
timgent
commented
Jul 6, 2021
| def generateRawCheckResult(qcType: QcType, suffix: String, status: CheckStatus) = | ||
| CheckResult(qcType, status, s"checkResult$suffix", SimpleCheckDescription(s"checkDescription$suffix")) | ||
|
|
||
| val uri = uri"http://127.0.0.1:8080" |
Owner
Author
There was a problem hiding this comment.
We should not post to a real endpoint in unit tests... unless we really want this to be an integration test
There was a problem hiding this comment.
You can test this one with some mocking API tool (e.g. RestAssured)
timgent
commented
Jul 6, 2021
| with EsTestUtils | ||
| with ScalaCheckDrivenPropertyChecks { | ||
|
|
||
| "DfApiResultsRepository.save" should { |
Owner
Author
There was a problem hiding this comment.
Need to add some unhappy path tests for this too
|
A great feature. Well anticipated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs some review and definitely error handling needs to be improved