Merged
Conversation
timhanlon
approved these changes
Mar 4, 2025
Owner
|
Amazing, thanks! |
Collaborator
Author
|
One thing it could do with would be a default layout. Perhaps we can do that with runtime config. |
davestewart
added a commit
that referenced
this pull request
Mar 4, 2025
* main: feat: add story layout prop (#19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds
layoutprops toStorycomponents:It attempts to mirror our used functionality from Histoire, but also:
colsvalue (rather than entering percentages)<width>pxvalue (fixes pixel value and wraps)<width>%value (calculatescolsand wraps)type: gridvalue is not strictly required; can just enter{ cols: 4 }and it is inferredIt also makes some decisions on styling:
1.5remScreenshots